Skip to content

Windows and WSL: SI/SO/IBMPC_ON/IBMPC_OFF skip #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

penguinolog
Copy link
Collaborator

In the case of Windows terminal, output is always Unicode and escape sequences for charset manipulation are "garbage"

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

Partial #774

@penguinolog penguinolog added Unicode Issues related to Unicode <-> bytes conversion Windows Windows support labels Feb 1, 2024
@coveralls
Copy link

coveralls commented Feb 1, 2024

Pull Request Test Coverage Report for Build 7746319870

  • -12 of 14 (14.29%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 70.941%

Changes Missing Coverage Covered Lines Changed/Added Lines %
urwid/display/_raw_display_base.py 2 14 14.29%
Totals Coverage Status
Change from base Build 7739473140: -0.02%
Covered Lines: 8771
Relevant Lines: 12453

💛 - Coveralls

In the case of Windows terminal, output is always Unicode
and escape sequences for charset manipulation are "garbage"
@penguinolog penguinolog force-pushed the windows_garbage_commands branch from 2a3f5e9 to 562a4dc Compare February 1, 2024 19:03
if first or lasta != a:
o.append(attr_to_escape(a))
lasta = a
if first or lastcs != cs:

if not (IS_WINDOWS or IS_WSL) and (first or lastcs != cs):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically it's not needed at all if console is Unicode but need deeper testing.

@penguinolog penguinolog merged commit 58ce51a into urwid:master Feb 1, 2024
@penguinolog penguinolog added the bug label Feb 1, 2024
@penguinolog penguinolog deleted the windows_garbage_commands branch February 1, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unicode Issues related to Unicode <-> bytes conversion Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants