Typing: annotate text_layout and extend Text/Edit#793
Merged
penguinolog merged 1 commit intourwid:masterfrom Feb 7, 2024
Merged
Typing: annotate text_layout and extend Text/Edit#793penguinolog merged 1 commit intourwid:masterfrom
Text/Edit#793penguinolog merged 1 commit intourwid:masterfrom
Conversation
Pull Request Test Coverage Report for Build 7812944319
💛 - Coveralls |
* `Canvas`: do not accept any arguments in the constructor. Arguments deprecated many years ago, renamed error was raise before. * `StandardTextLayout`: split `calculate_text_segments` scenario for `clip` and `ellipsis` from `any` and `space`. Extremely long methods with 2 main branches. Use human-friendly variable naming. * `Text`/`Edit`: In several methods intentionally do not mark bytes as valid argument: Due to the amount of transcoding, `str` is absolute priority
e98b253 to
b76efdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canvas: do not accept any arguments in the constructor. Arguments deprecated many years ago, renamed error was raise before.StandardTextLayout: splitcalculate_text_segmentsscenario forclipandellipsisfromanyandspace. Extremely long methods with 2 main branches. Use human-friendly variable naming.Text/Edit: In several methods intentionally do not markbytesas valid argument: Due to the amount of transcoding,stris absolute priorityChecklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment