Skip to content

Fix MinLoop.watch_pipe regression for the callback outcome not False#848

Merged
penguinolog merged 1 commit intourwid:masterfrom
penguinolog:watch_pipe_implicit_none
Feb 28, 2024
Merged

Fix MinLoop.watch_pipe regression for the callback outcome not False#848
penguinolog merged 1 commit intourwid:masterfrom
penguinolog:watch_pipe_implicit_none

Conversation

@penguinolog
Copy link
Collaborator

Start adding unittests for MainLoop since it had ~0% of real coverage

Fix: #847

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

@coveralls
Copy link

coveralls commented Feb 28, 2024

Pull Request Test Coverage Report for Build 8078284597

Details

  • -1 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 74.364%

Changes Missing Coverage Covered Lines Changed/Added Lines %
urwid/event_loop/main_loop.py 4 5 80.0%
Totals Coverage Status
Change from base Build 8069409807: 1.9%
Covered Lines: 9274
Relevant Lines: 12611

💛 - Coveralls

Start adding unittests for `MainLoop` since it had ~0% of real coverage

Fix: urwid#847
@penguinolog penguinolog force-pushed the watch_pipe_implicit_none branch from 944dc9a to 50fd33f Compare February 28, 2024 09:40
@penguinolog penguinolog merged commit 210a79d into urwid:master Feb 28, 2024
@penguinolog penguinolog deleted the watch_pipe_implicit_none branch February 28, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] MainLoop.watch_pipe is closed after the first callback

2 participants