Skip to content

Fix ScrollBar mouse_event handling with ListBox#905

Merged
penguinolog merged 1 commit intourwid:masterfrom
skimmmer:scrollbar-listbox-mouseevent-handled
Jun 12, 2024
Merged

Fix ScrollBar mouse_event handling with ListBox#905
penguinolog merged 1 commit intourwid:masterfrom
skimmmer:scrollbar-listbox-mouseevent-handled

Conversation

@skimmmer
Copy link
Contributor

@skimmmer skimmmer commented Jun 12, 2024

Propagate handled from ScrollBar if original widget (ListBox) handled the event.

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
Description:

If original widget (i.e. ListBox) handles the event, return True indicating that the event was handled.

Fixes #904

Propagate handled from ScrollBar if original widget
(ListBox) handled the event.
@coveralls
Copy link

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9477495461

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.741%

Totals Coverage Status
Change from base Build 9463006499: 0.0%
Covered Lines: 9412
Relevant Lines: 12740

💛 - Coveralls

@penguinolog penguinolog merged commit c47735c into urwid:master Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ScrollBar does not indicate mouse_event was handled with ListBox

3 participants