Skip to content

Fix ListBox.rows_max calculation for empty container#910

Merged
penguinolog merged 1 commit into
urwid:masterfrom
penguinolog:bug_rows_max_listbox
Jul 3, 2024
Merged

Fix ListBox.rows_max calculation for empty container#910
penguinolog merged 1 commit into
urwid:masterfrom
penguinolog:bug_rows_max_listbox

Conversation

@penguinolog

Copy link
Copy Markdown
Collaborator

In case of empty container,
get_focus will return None, None

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

In case of empty container,
`get_focus` will return `None, None`
@coveralls

coveralls commented Jul 3, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 9775555283

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 74.746%

Totals Coverage Status
Change from base Build 9739331036: 0.005%
Covered Lines: 9413
Relevant Lines: 12741

💛 - Coveralls

@penguinolog penguinolog merged commit b4818a7 into urwid:master Jul 3, 2024
@penguinolog penguinolog deleted the bug_rows_max_listbox branch July 3, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants