Add 16-color support - #939
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 11342029412Details
💛 - Coveralls |
penguinolog
requested changes
Oct 15, 2024
penguinolog
left a comment
Collaborator
There was a problem hiding this comment.
Please add comment explaining colors, because both are 16 colors.
And good to mark that not all terminals will display these colors as bright.
Co-authored-by: Alexey Stepanov <penguinolog@users.noreply.github.com>
penguinolog
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranchtoxsuccessfully in local environmentDescription:
This fixes a very minor issue where bright ANSI escape codes are ignored
It is quite literally 4 lines of code, not sure how it was missed but oh well