Skip to content

Add 16-color support - #939

Merged
penguinolog merged 3 commits into
urwid:masterfrom
luca-script:master
Oct 15, 2024
Merged

Add 16-color support#939
penguinolog merged 3 commits into
urwid:masterfrom
luca-script:master

Conversation

@luca-script

Copy link
Copy Markdown
Contributor
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • (Not applicable) I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)
Description:

This fixes a very minor issue where bright ANSI escape codes are ignored
It is quite literally 4 lines of code, not sure how it was missed but oh well

@coveralls

coveralls commented Oct 10, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 11342029412

Details

  • 2 of 6 (33.33%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 74.594%

Changes Missing Coverage Covered Lines Changed/Added Lines %
urwid/vterm.py 2 6 33.33%
Files with Coverage Reduction New Missed Lines %
urwid/command_map.py 7 74.55%
Totals Coverage Status
Change from base Build 11216432039: -0.2%
Covered Lines: 9419
Relevant Lines: 12753

💛 - Coveralls

@penguinolog penguinolog left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comment explaining colors, because both are 16 colors.
And good to mark that not all terminals will display these colors as bright.

Comment thread urwid/vterm.py
Co-authored-by: Alexey Stepanov <penguinolog@users.noreply.github.com>
@penguinolog
penguinolog merged commit 19aecde into urwid:master Oct 15, 2024
@penguinolog penguinolog added the Feature Feature request/implementation label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Feature request/implementation Widget

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants