Skip to content

Type annotations: fix typing issues#941

Merged
penguinolog merged 1 commit into
urwid:masterfrom
penguinolog:typing_issues
Oct 15, 2024
Merged

Type annotations: fix typing issues#941
penguinolog merged 1 commit into
urwid:masterfrom
penguinolog:typing_issues

Conversation

@penguinolog

Copy link
Copy Markdown
Collaborator
  • Combining deprecated typing with annotations enabled
  • Using Collection and expecting __getitem__
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

* Combining deprecated typing with annotations enabled
* Using `Collection` and expecting `__getitem__`
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 11341327432

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 74.603%

Totals Coverage Status
Change from base Build 11340731760: -0.001%
Covered Lines: 9417
Relevant Lines: 12747

💛 - Coveralls

@penguinolog
penguinolog merged commit 1acc2ce into urwid:master Oct 15, 2024
@penguinolog
penguinolog deleted the typing_issues branch October 15, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants