New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Erubis instead of ERB #7

Merged
merged 1 commit into from Nov 19, 2016

Conversation

Projects
None yet
2 participants
@guilleiguaran
Collaborator

guilleiguaran commented Nov 18, 2016

Erubis is a faster implementation of ERB and Rails ships with erubis since Rails 3.0 so it can be used in any rails project.

@rhys-vdw

This comment has been minimized.

Show comment
Hide comment
@rhys-vdw

rhys-vdw Nov 19, 2016

Collaborator

@guilleiguaran Thanks for the PR! 👍 I wasn't aware of Erubis. I think it's safe to use this as the rendering engine since it's been included with Rails since 2010.

We don't have benchmarking (or even tests) set up for this loader, but some Googling confirmed a general consensus that Erubis is faster (their own benchmark is available at the bottom of this page.

I did some very informal comparisons against our project, turning cacheable off, and saw a (small) improvement in build times. I assume this would be more pronounced with more complex templates.

I'm adding you as a collaborator. Feel free to contribute as little or as much as you please!

Collaborator

rhys-vdw commented Nov 19, 2016

@guilleiguaran Thanks for the PR! 👍 I wasn't aware of Erubis. I think it's safe to use this as the rendering engine since it's been included with Rails since 2010.

We don't have benchmarking (or even tests) set up for this loader, but some Googling confirmed a general consensus that Erubis is faster (their own benchmark is available at the bottom of this page.

I did some very informal comparisons against our project, turning cacheable off, and saw a (small) improvement in build times. I assume this would be more pronounced with more complex templates.

I'm adding you as a collaborator. Feel free to contribute as little or as much as you please!

@rhys-vdw rhys-vdw merged commit 3332b2e into usabilityhub:master Nov 19, 2016

@rhys-vdw

This comment has been minimized.

Show comment
Hide comment
@rhys-vdw

rhys-vdw Nov 19, 2016

Collaborator

I've just released v3 with your changes. I did a major version update because theoretically this might break someone's build if they're using an older version of Rails. In practise I doubt very much that it will be a problem.

Collaborator

rhys-vdw commented Nov 19, 2016

I've just released v3 with your changes. I did a major version update because theoretically this might break someone's build if they're using an older version of Rails. In practise I doubt very much that it will be a problem.

@guilleiguaran

This comment has been minimized.

Show comment
Hide comment
@guilleiguaran

guilleiguaran Nov 19, 2016

Collaborator

Sounds good, thank you very much!!!!

Collaborator

guilleiguaran commented Nov 19, 2016

Sounds good, thank you very much!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment