New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usabilla 5.1.4 fails on release build #121

Open
koenpunt opened this Issue Nov 1, 2018 · 16 comments

Comments

Projects
None yet
8 participants
@koenpunt

koenpunt commented Nov 1, 2018

While building my project for release, the build fails with the following output;

The following build commands failed:

CompileSwift normal armv7 /Users/Shared/Jenkins/Home/workspace/ios-app/UW/SwiftCompatibility/UsabillaBridge.swift

CompileSwift normal armv7 /Users/Shared/Jenkins/Home/workspace/ios-app/UW/Shared/Navigation/UWViewController+UsabillaDelegate.swift

CompileSwiftSources normal armv7 com.apple.xcode.tools.swift.compiler
@edwinveger

This comment has been minimized.

edwinveger commented Nov 7, 2018

@andlie Is anyone looking into this?

@sudhyk

This comment has been minimized.

sudhyk commented Nov 7, 2018

Seeing the same, any updates on this ?

@diederikh

This comment has been minimized.

diederikh commented Nov 7, 2018

Same problem here. I've tried the binaries in the 5.1.4 release but that one only has x86_64 and arm64 versions of the framework.

@michel-moreau

This comment has been minimized.

michel-moreau commented Nov 13, 2018

Same issue here.

@JuLink

This comment has been minimized.

JuLink commented Nov 13, 2018

Same

1 similar comment
@ANGOmarcello

This comment has been minimized.

ANGOmarcello commented Nov 13, 2018

Same

@ANGOmarcello

This comment has been minimized.

ANGOmarcello commented Nov 13, 2018

5.1.2 is the last known stable version for us

@torkvell

This comment has been minimized.

torkvell commented Nov 13, 2018

Hi @koenpunt. Thanks for reporting. Do note that the release from 5.1.3 only supports 64-bit modules. This is due to the update from Apple's side where new apps must support 64-bit. More can be read here: https://developer.apple.com/news/?id=04112018a

@diederikh

This comment has been minimized.

diederikh commented Nov 13, 2018

@torkvell Apple requiring supporting 64bit does not mean removing support for older arm versions. iPhone 5/5c (iOS 10+) are still on arm7 (see http://iossupportmatrix.com).

@ANGOmarcello

This comment has been minimized.

ANGOmarcello commented Nov 13, 2018

As we use Usabilla in a huge corporate project that still supports iOS 9 I really have to agree with @diederikh. Theres no problem with supporting all these architectures at once.

@koenpunt

This comment has been minimized.

koenpunt commented Nov 13, 2018

I have to agree with @diederikh
@torkvell that's quite an unthoughtful decision. I will have someone reach out to the customer success manager, because this is not acceptable.

@torkvell

This comment has been minimized.

torkvell commented Nov 14, 2018

Hi all,

First off, we would like to offer you our apologies for the lack of clarity about our latest release. We can only agree that we could have communicated this better.

Regarding our decision to not include 32-bit in version 5.1.4: as said, Apple deciding to shift their focus from 32-bit to 64-bit was and is an important factor for us. However, we appreciate your feedback. We have brought this up with our Product Team and they've confirmed they will make sure the build of our next major version will support 32-bit as well.

To avoid any misunderstandings: version 5.1.2. is still a stable version and does support 32-bit. You can still use this version in the meantime without any difficulties.

@JuLink

This comment has been minimized.

JuLink commented Nov 14, 2018

Hi @torkvell,

I'm glad that you are reconsidering the 32-bit drop for your futur release.

But the situation right now is that we can't use Xcode 10.1 because Usabilla is blocking us if we want to support iOS 10. To support iOS 10 we have to be able to build for iPhone 5/5C and iPad 4th Gen and to achieve this, we need a 32bit framework of Usabilla.

As you mention, the release that is 32bit compliant is the 5.1.2 but this release is built with Xcode 10.0 and Swift 4.2. Xcode 10.1 is shipped with Swift 4.2.1. This makes the binary of Usabilla incompatible.

So we have to either stay with Xcode 10.0 and the release 5.1.2, use Xcode 10.1 and drop iOS 10 support and use 5.1.4...

@koenpunt

This comment has been minimized.

koenpunt commented Nov 14, 2018

As you mention, the release that is 32bit compliant is the 5.1.2 but this release is built with Xcode 10.0 and Swift 4.2. Xcode 10.1 is shipped with Swift 4.2.1. This makes the binary of Usabilla incompatible.

We were able to use 5.1.2 with Xcode 10.1..

@JuLink

This comment has been minimized.

JuLink commented Nov 14, 2018

@koenpunt with Carthage?
Every time I try to Carthage update I get the message saying that the Usabilla framework it build with Swift 4.2 and not 4.2.1.

@koenpunt

This comment has been minimized.

koenpunt commented Nov 14, 2018

@koenpunt with Carthage?

Nope, cocoapods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment