Repositioning Tooltip for responsive sites on window resize #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "intro.js", | |||
| "description": "Better introductions for websites and features with a step-by-step guide for your projects", | |||
| "version": "2.0", | |||
| "version": "2.0.0", | |||
There was a problem hiding this comment.
Can you please remove this change?
Adding default position might be useful for responsive site repositioning. Moving resize inside if conditions to get reference objects for _palceTooltip
|
I tried to use this fix for Version 2.3.0 but unfortunately it's only working for 2.0.0. Is there any chance that this issue is fixed in the next version? Or has anyone a working fix for 2.3.0? |
|
nice one but doesn't work properly with latest version. could you please have a look? |
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For responsives site, I moved onresize function on _showElement and call on resize + _placeTooltip for repositioning on responsive sites