Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-added PR #80 for groups #763

Merged
merged 4 commits into from Feb 23, 2018
Merged

Re-added PR #80 for groups #763

merged 4 commits into from Feb 23, 2018

Conversation

bozdoz
Copy link
Collaborator

@bozdoz bozdoz commented Sep 26, 2017

I omitted changes to css and minified files, and added an example.

@afshinm
Copy link
Contributor

afshinm commented Oct 8, 2017

Hmm, nice. The thing is, we can already pass a parent element and start the intro for a specific container rather than document.body.

Do you think these two have conflict with each other?

@bozdoz
Copy link
Collaborator Author

bozdoz commented Oct 8, 2017

I think it would find the group matches within the selected element, wouldn't it? Don't think it would conflict.

@afshinm
Copy link
Contributor

afshinm commented Oct 12, 2017

@bozdoz
Copy link
Collaborator Author

bozdoz commented Oct 12, 2017

That's quite an involved StackOverflow question, so I am not sure. My best guess use-case is to run one introjs after another, like in the example I posted with it: one iterated even numbered sections and the other iterated the odd, and there was a button for each.

@bozdoz bozdoz merged commit 2a0e609 into master Feb 23, 2018
@afshinm afshinm deleted the crowdlab-upstream branch November 27, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants