Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usagov-809-remove-role-group: usagov-809-remove-roll-group #775

Merged
merged 1 commit into from Mar 27, 2023

Conversation

developer43
Copy link
Contributor

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-809

Description

Inspect code and make sure "role=group" is removed from the fieildset tag on the scams sub pages.
http://localhost/where-report-scams/what-type-scam-do-you-need-report#block-usagov-content

Checklist for the Developer

  • A link to the JIRA ticket has been added above.
  • The JIRA ticket identifies the desired result of this change.
  • The JIRA ticket contains clear acceptance criteria.
  • The JIRA ticket contains clear testing steps.
  • The JIRA ticket contains a description of "Done".
  • Any preparation/installation/update steps required for this code to work properly (drush commands, scripts, configuration updates) are documented in the ticket.

Checklist for the Peer Reviewers

  • The branch name of this PR matches the project standards.
  • QA steps are followed and any changes to process are updated in the ticket.
  • Code Standards are followed, there are no bad practices in use.
  • Config changes (if any) include only necessary changes.
  • No errors in Drupal or Client Browser.
  • Code has been tested locally (if possible).
  • Following AC and Testing Steps verify changes work as expected.
  • There are no known side-effects outside of expected behavior.

@IsabelLaurenceau IsabelLaurenceau merged commit 2930a36 into dev Mar 27, 2023
1 of 2 checks passed
@IsabelLaurenceau IsabelLaurenceau deleted the usagov-809-remove-role-group branch March 27, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants