Jump to conversation
Unresolved conversations (5)
@kjrush kjrush Nov 23, 2021
Is there any sort of issue with this where a calling component might think the node is actually loaded and act on that assumption some how?
...utils/src/lifecycle_component_wrapper.cpp
msmcconnell
@kjrush kjrush Nov 23, 2021
Huh, I didn't even know this sort of class introspection/meta programming was possible in CPP.
...utils/src/lifecycle_component_wrapper.cpp
@kjrush kjrush Nov 23, 2021
Is this a ROS2 cpp library for accessing files based on the installed location of the ROS package? Has something like that existed in ROS1 or is that new? Neat.
...utils/src/lifecycle_component_wrapper.cpp
msmcconnell
@kjrush kjrush Nov 23, 2021
Yeah, like this applied to the CPP file above.
...os2_utils/lifecycle_component_wrapper.hpp
@kjrush kjrush Nov 23, 2021
Not actually clear to me what the proper copyright notice is here, since it's based off of theirs as a template. At minimum I'd add a note stating that, I think.
...carma_ros2_utils/carma_lifecycle_node.hpp
msmcconnell
Resolved conversations (1)
@kjrush kjrush Nov 23, 2021
is the leading `_` to imply private, similar to how it's used in python? Or is this formally enforced in ROS2?
...utils/src/lifecycle_component_wrapper.cpp
msmcconnell