Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedded needs in embedded needs are not supported #486

Closed
PhilipPartsch opened this issue Jan 29, 2022 · 1 comment
Closed

embedded needs in embedded needs are not supported #486

PhilipPartsch opened this issue Jan 29, 2022 · 1 comment

Comments

@PhilipPartsch
Copy link
Contributor

PhilipPartsch commented Jan 29, 2022

An embedded need in an embedded need is not supported:

.. req:: Bread
   :id: bread_req_2
   :value: 30
   :unit: cm
   
   Our bread includes sausage.
   
   .. req:: Sausage
      :id: sausage_req_2
      :value: 30
      :unit: cm

      The sausage is delicious and on top is some ketchup.

      .. req:: Ketchup
         :id: Ketchup_req_2

          The ketchup is tasty.

   .. req:: Onion
      :id: onion_req_2

      The onions are delicious.

In the html or needs.json the parent_needs are always empty.

Secondly, the algorithm to get the parents /childs, is fetching even parents of the parents and so on. In a model of the relations, this is not good practice. We shall only provide the real parents of need (and do not give back the grands as parents, too). This is especially bad, as the grands would mark grandchilds as children, too.

@PhilipPartsch
Copy link
Contributor Author

@danwos can you close this ticket?

@danwos danwos closed this as completed Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants