-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to accept self-signed certificates #211
Comments
I just found the option in the UI. Apologies for the noise! |
No worries :) |
For all those finding this through search, the option is on settings off the gear icon on the bottom left, not the top right. |
for those that got a preference save error one has to set the proxy.port to a number e.g. 1000 even when not used ( output from devtools :) |
Hi all, seems like I'm running into the same issue. I am using a self-signed cert with my own custom CA. Deactivating SSL Certificate Validation does not work even after restart of Bruno - I am still getting |
I'm in the same boat as @Schm1tz1 :
I'm on Bruno 1.3.0 MacOS 14.1.2 |
Hello @Shackelford-Arden and @geraintwjones , could you please try again on Bruno 1.3.2, as it include fixes related to localhost environment if you was having the SSL issue on localhost |
I'm getting |
@BrandonGillis having updated to 1.3.2, I still need to set the environment variable when opening Bruno to make calls against self-signed certs w/ validation turned off. Just for clarity, here is the SSL/TLS Cerficiate Verification turned off: Error when attempting to make call against self-signed resource: Same settings but running Bruno like this:
Gets the response I expected. |
@Shackelford-Arden I tried that. I get the same error as before. Also, by starting Bruno like this...
I get the following output... |
Support for specifying Custom CA is now available in v1.6.0 🎉 🎉 @Shackelford-Arden @Schm1tz1 @geraintwjones The release also involves fixes for the issue you were facing. Can you download 1.6.0 and see if it solves your issue ? |
@ivycristina Can you share more details Did you try disabling ssl? |
I disabled SSL because it was giving another error and I threw it on the internet and said to disable it, I'm not using a certificate, I just brought the collection directly from postman to Bruno and there in postman it works without any token or certificate and here it doesn't want to work |
@helloanoop - at least for me I can say that the issues are gone now, thanks a lot! |
@helloanoop I'm on Bruno 1.6.1 and I still need to use the following to successfully make HTTPS. Again for reference, I do have SSL verification disabled: I do have a SOCKS5 proxy for these requests in particular. Error message I'm getting: Seems like there needs to be a way to make sure that validation for all certificates that are presented is skipped. |
As an additional point there, if I run the same request via cURL while telling it to use the same proxy, the request is successful |
@helloanoop @Shackelford-Arden Currently it is implemented like this: if (socksEnabled) {
const socksProxyAgent = new SocksProxyAgent(proxyUri);
request.httpsAgent = socksProxyAgent;
request.httpAgent = socksProxyAgent;
} So it completely ignores SSL verification and certificates configuration in I think it should be changed to something like this: if (socksEnabled) {
request.httpsAgent = new SocksProxyAgent(
proxyUri,
Object.keys(httpsAgentRequestFields).length > 0 ? { ...httpsAgentRequestFields } : undefined
);
request.httpAgent = new SocksProxyAgent(proxyUri);
} the same way how it is implemented for http(s) proxy. |
@martinsefcik Nice find :) As a quick test, I did the following to see if that would work:
|
Great! I can prepare PR for that tomorrow. |
@geraintwjones @ivycristina Were you using also SOCKS proxy as @Shackelford-Arden when you had these errors ? |
|
hello, I am using bruno-cli and wanted to generate a reports of the tests in html does it have this option? |
It seems that the issue has been resolved, so I am closing this. |
@sanjai0py bruno-cli does not support this option. I think the best way to get around this is to enable accept self-signed certificates in collection setting so it can be picked up by bruno-cli. What do you think? should I create a separate issue? |
Hi,
First of all, thanks for creating and developing Bruno!
I started to migrate my Postman collections to Bruno, and I'm facing the following error when running requests:
The target server is indeed using self-signed certificates, as it is a development server used for testing.
Would it be possible to add an option to ignore this case?
I could do a tiny workaround in macOS using the terminal:
Thanks in advance!
The text was updated successfully, but these errors were encountered: