Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SiteSwitcher work on touch devices #164

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
2 participants
@samuelmeuli
Copy link
Contributor

samuelmeuli commented Oct 17, 2018

This PR makes it possible to use the SiteSwitcher on touch devices. This wasn't possible before because opening it required the user to hover on the dropdown.

@dannyvankooten

This comment has been minimized.

Copy link
Collaborator

dannyvankooten commented Oct 19, 2018

Hey @samuelmeuli,

On which touch devices is this specifically? Because I was under the impression that on touch devices, the hover event was triggered when tapping the element and my tests on iPhone & Nexus seem to confirm that.

@samuelmeuli

This comment has been minimized.

Copy link
Contributor Author

samuelmeuli commented Oct 19, 2018

Weird. I'm also using an iPhone (Safari, iOS 12) and it's not working for me. I can get the dropdown to open by tapping on the <a> element inside the dropdown, but I can't get it to close afterwards, neither by tapping on the link again nor by selecting a different site.

@dannyvankooten dannyvankooten merged commit 036c369 into usefathom:master Oct 26, 2018

@dannyvankooten

This comment has been minimized.

Copy link
Collaborator

dannyvankooten commented Oct 26, 2018

Sorry for the wait on this one. It seems to be affecting Safari on iOS, but not Chrome or Firefox.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.