From 923e4e0557128494687ead6487b997fba6d68660 Mon Sep 17 00:00:00 2001 From: Alasdair Stalker Date: Fri, 21 Apr 2017 13:45:48 +0100 Subject: [PATCH] fix(cache): Dont save to cache when data invalid --- src/Contentful.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/Contentful.php b/src/Contentful.php index b1a14f9..bcbc85d 100644 --- a/src/Contentful.php +++ b/src/Contentful.php @@ -586,8 +586,12 @@ function ($builtResponse) use ($test) { //save into cache if ($api !== self::CONTENT_MANAGEMENT_API) { $isSuccessResponseData = !$unavailableException && $isValidResponse; - $writeCacheItem->set($responseJson); - $writeCache->save($writeCacheItem); + + if ($isSuccessResponseData || $this->cacheFailResponses) { + $writeCacheItem->set($responseJson); + $writeCache->save($writeCacheItem); + } + if (!isset($fallbackCacheItem)) { /** * @var CacheItemInterface $fallbackCacheItem