commit 892a2af03faf3f71b3543fee0e3743b1275f4f70 Author: Coleen Phillimore Date: Wed Jun 6 10:45:40 2018 -0400 8204301: Make OrderAccess functions available to hpp rather than inline.hpp files Move orderAccess.inline.hpp into orderAccess.hpp and remove os.hpp inclusion and conditional os::is_MP() for fence on x86 platforms Reviewed-by: dholmes, hseigel diff --git a/src/hotspot/cpu/arm/relocInfo_arm.cpp b/src/hotspot/cpu/arm/relocInfo_arm.cpp index f11c1b8201b..6d38ab8fd3b 100644 --- a/src/hotspot/cpu/arm/relocInfo_arm.cpp +++ b/src/hotspot/cpu/arm/relocInfo_arm.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2008, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,7 +29,7 @@ #include "nativeInst_arm.hpp" #include "oops/compressedOops.inline.hpp" #include "oops/oop.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/safepoint.hpp" void Relocation::pd_set_data_value(address x, intptr_t o, bool verify_only) { diff --git a/src/hotspot/cpu/ppc/nativeInst_ppc.cpp b/src/hotspot/cpu/ppc/nativeInst_ppc.cpp index f962545702c..67289e91238 100644 --- a/src/hotspot/cpu/ppc/nativeInst_ppc.cpp +++ b/src/hotspot/cpu/ppc/nativeInst_ppc.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2012, 2015 SAP SE. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -30,7 +30,7 @@ #include "oops/compressedOops.inline.hpp" #include "oops/oop.hpp" #include "runtime/handles.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/sharedRuntime.hpp" #include "runtime/stubRoutines.hpp" #include "utilities/ostream.hpp" diff --git a/src/hotspot/cpu/zero/cppInterpreter_zero.cpp b/src/hotspot/cpu/zero/cppInterpreter_zero.cpp index 43e03b74224..0d2ef9ff73a 100644 --- a/src/hotspot/cpu/zero/cppInterpreter_zero.cpp +++ b/src/hotspot/cpu/zero/cppInterpreter_zero.cpp @@ -43,7 +43,7 @@ #include "runtime/frame.inline.hpp" #include "runtime/interfaceSupport.inline.hpp" #include "runtime/jniHandles.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/sharedRuntime.hpp" #include "runtime/stubRoutines.hpp" #include "runtime/synchronizer.hpp" diff --git a/src/hotspot/os/aix/os_aix.cpp b/src/hotspot/os/aix/os_aix.cpp index 08da5392a7d..5cc5de70253 100644 --- a/src/hotspot/os/aix/os_aix.cpp +++ b/src/hotspot/os/aix/os_aix.cpp @@ -59,7 +59,7 @@ #include "runtime/javaCalls.hpp" #include "runtime/mutexLocker.hpp" #include "runtime/objectMonitor.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.hpp" #include "runtime/osThread.hpp" #include "runtime/perfMemory.hpp" diff --git a/src/hotspot/os/bsd/os_bsd.cpp b/src/hotspot/os/bsd/os_bsd.cpp index f33ed42d75e..ba11ba4a48c 100644 --- a/src/hotspot/os/bsd/os_bsd.cpp +++ b/src/hotspot/os/bsd/os_bsd.cpp @@ -49,7 +49,7 @@ #include "runtime/javaCalls.hpp" #include "runtime/mutexLocker.hpp" #include "runtime/objectMonitor.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/osThread.hpp" #include "runtime/perfMemory.hpp" #include "runtime/semaphore.hpp" diff --git a/src/hotspot/os/linux/os_linux.cpp b/src/hotspot/os/linux/os_linux.cpp index ab19d1da824..e6d0fe37beb 100644 --- a/src/hotspot/os/linux/os_linux.cpp +++ b/src/hotspot/os/linux/os_linux.cpp @@ -51,7 +51,7 @@ #include "runtime/javaCalls.hpp" #include "runtime/mutexLocker.hpp" #include "runtime/objectMonitor.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/osThread.hpp" #include "runtime/perfMemory.hpp" #include "runtime/sharedRuntime.hpp" diff --git a/src/hotspot/os/solaris/os_solaris.cpp b/src/hotspot/os/solaris/os_solaris.cpp index 01a3c292d1b..d8c56353760 100644 --- a/src/hotspot/os/solaris/os_solaris.cpp +++ b/src/hotspot/os/solaris/os_solaris.cpp @@ -49,7 +49,7 @@ #include "runtime/javaCalls.hpp" #include "runtime/mutexLocker.hpp" #include "runtime/objectMonitor.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/osThread.hpp" #include "runtime/perfMemory.hpp" #include "runtime/sharedRuntime.hpp" diff --git a/src/hotspot/os/windows/os_windows.cpp b/src/hotspot/os/windows/os_windows.cpp index 81adb9e32e4..00fc92384ac 100644 --- a/src/hotspot/os/windows/os_windows.cpp +++ b/src/hotspot/os/windows/os_windows.cpp @@ -52,7 +52,7 @@ #include "runtime/javaCalls.hpp" #include "runtime/mutexLocker.hpp" #include "runtime/objectMonitor.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/osThread.hpp" #include "runtime/perfMemory.hpp" #include "runtime/sharedRuntime.hpp" diff --git a/src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.inline.hpp b/src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.hpp similarity index 94% rename from src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.inline.hpp rename to src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.hpp index 070c2169461..81427eb8ca5 100644 --- a/src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.inline.hpp +++ b/src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.hpp @@ -23,10 +23,10 @@ * */ -#ifndef OS_CPU_AIX_OJDKPPC_VM_ORDERACCESS_AIX_PPC_INLINE_HPP -#define OS_CPU_AIX_OJDKPPC_VM_ORDERACCESS_AIX_PPC_INLINE_HPP +#ifndef OS_CPU_AIX_OJDKPPC_VM_ORDERACCESS_AIX_PPC_HPP +#define OS_CPU_AIX_OJDKPPC_VM_ORDERACCESS_AIX_PPC_HPP -#include "runtime/orderAccess.hpp" +// Included in orderAccess.hpp header file. // Compiler version last used for testing: xlc 12 // Please update this information when this file changes @@ -90,4 +90,4 @@ struct OrderAccess::PlatformOrderedLoad #undef inlasm_eieio #undef inlasm_isync -#endif // OS_CPU_AIX_OJDKPPC_VM_ORDERACCESS_AIX_PPC_INLINE_HPP +#endif // OS_CPU_AIX_OJDKPPC_VM_ORDERACCESS_AIX_PPC_HPP diff --git a/src/hotspot/os_cpu/bsd_x86/orderAccess_bsd_x86.inline.hpp b/src/hotspot/os_cpu/bsd_x86/orderAccess_bsd_x86.hpp similarity index 86% rename from src/hotspot/os_cpu/bsd_x86/orderAccess_bsd_x86.inline.hpp rename to src/hotspot/os_cpu/bsd_x86/orderAccess_bsd_x86.hpp index 0e13f1c75c3..7a59abe3a80 100644 --- a/src/hotspot/os_cpu/bsd_x86/orderAccess_bsd_x86.inline.hpp +++ b/src/hotspot/os_cpu/bsd_x86/orderAccess_bsd_x86.hpp @@ -22,12 +22,10 @@ * */ -#ifndef OS_CPU_BSD_X86_VM_ORDERACCESS_BSD_X86_INLINE_HPP -#define OS_CPU_BSD_X86_VM_ORDERACCESS_BSD_X86_INLINE_HPP +#ifndef OS_CPU_BSD_X86_VM_ORDERACCESS_BSD_X86_HPP +#define OS_CPU_BSD_X86_VM_ORDERACCESS_BSD_X86_HPP -#include "runtime/atomic.hpp" -#include "runtime/orderAccess.hpp" -#include "runtime/os.hpp" +// Included in orderAccess.hpp header file. // Compiler version last used for testing: clang 5.1 // Please update this information when this file changes @@ -52,14 +50,12 @@ inline void OrderAccess::acquire() { compiler_barrier(); } inline void OrderAccess::release() { compiler_barrier(); } inline void OrderAccess::fence() { - if (os::is_MP()) { - // always use locked addl since mfence is sometimes expensive + // always use locked addl since mfence is sometimes expensive #ifdef AMD64 - __asm__ volatile ("lock; addl $0,0(%%rsp)" : : : "cc", "memory"); + __asm__ volatile ("lock; addl $0,0(%%rsp)" : : : "cc", "memory"); #else - __asm__ volatile ("lock; addl $0,0(%%esp)" : : : "cc", "memory"); + __asm__ volatile ("lock; addl $0,0(%%esp)" : : : "cc", "memory"); #endif - } compiler_barrier(); } @@ -113,4 +109,4 @@ struct OrderAccess::PlatformOrderedStore<8, RELEASE_X_FENCE> }; #endif // AMD64 -#endif // OS_CPU_BSD_X86_VM_ORDERACCESS_BSD_X86_INLINE_HPP +#endif // OS_CPU_BSD_X86_VM_ORDERACCESS_BSD_X86_HPP diff --git a/src/hotspot/os_cpu/bsd_zero/orderAccess_bsd_zero.inline.hpp b/src/hotspot/os_cpu/bsd_zero/orderAccess_bsd_zero.hpp similarity index 89% rename from src/hotspot/os_cpu/bsd_zero/orderAccess_bsd_zero.inline.hpp rename to src/hotspot/os_cpu/bsd_zero/orderAccess_bsd_zero.hpp index 96ea19a4a70..532b48be46d 100644 --- a/src/hotspot/os_cpu/bsd_zero/orderAccess_bsd_zero.inline.hpp +++ b/src/hotspot/os_cpu/bsd_zero/orderAccess_bsd_zero.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2018, Oracle and/or its affiliates. All rights reserved. * Copyright 2007, 2008, 2009 Red Hat, Inc. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -23,10 +23,10 @@ * */ -#ifndef OS_CPU_BSD_ZERO_VM_ORDERACCESS_BSD_ZERO_INLINE_HPP -#define OS_CPU_BSD_ZERO_VM_ORDERACCESS_BSD_ZERO_INLINE_HPP +#ifndef OS_CPU_BSD_ZERO_VM_ORDERACCESS_BSD_ZERO_HPP +#define OS_CPU_BSD_ZERO_VM_ORDERACCESS_BSD_ZERO_HPP -#include "runtime/orderAccess.hpp" +// Included in orderAccess.hpp header file. #ifdef ARM @@ -74,4 +74,4 @@ inline void OrderAccess::acquire() { LIGHT_MEM_BARRIER; } inline void OrderAccess::release() { LIGHT_MEM_BARRIER; } inline void OrderAccess::fence() { FULL_MEM_BARRIER; } -#endif // OS_CPU_BSD_ZERO_VM_ORDERACCESS_BSD_ZERO_INLINE_HPP +#endif // OS_CPU_BSD_ZERO_VM_ORDERACCESS_BSD_ZERO_HPP diff --git a/src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.inline.hpp b/src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.hpp similarity index 88% rename from src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.inline.hpp rename to src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.hpp index ac065069ebe..b733db19577 100644 --- a/src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.inline.hpp +++ b/src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.hpp @@ -23,12 +23,11 @@ * */ -#ifndef OS_CPU_LINUX_AARCH64_VM_ORDERACCESS_LINUX_AARCH64_INLINE_HPP -#define OS_CPU_LINUX_AARCH64_VM_ORDERACCESS_LINUX_AARCH64_INLINE_HPP +#ifndef OS_CPU_LINUX_AARCH64_VM_ORDERACCESS_LINUX_AARCH64_HPP +#define OS_CPU_LINUX_AARCH64_VM_ORDERACCESS_LINUX_AARCH64_HPP + +// Included in orderAccess.hpp header file. -#include "runtime/atomic.hpp" -#include "runtime/orderAccess.hpp" -#include "runtime/os.hpp" #include "vm_version_aarch64.hpp" // Implementation of class OrderAccess. @@ -71,4 +70,4 @@ struct OrderAccess::PlatformOrderedStore void operator()(T v, volatile T* p) const { release_store(p, v); fence(); } }; -#endif // OS_CPU_LINUX_AARCH64_VM_ORDERACCESS_LINUX_AARCH64_INLINE_HPP +#endif // OS_CPU_LINUX_AARCH64_VM_ORDERACCESS_LINUX_AARCH64_HPP diff --git a/src/hotspot/os_cpu/linux_arm/orderAccess_linux_arm.inline.hpp b/src/hotspot/os_cpu/linux_arm/orderAccess_linux_arm.hpp similarity index 95% rename from src/hotspot/os_cpu/linux_arm/orderAccess_linux_arm.inline.hpp rename to src/hotspot/os_cpu/linux_arm/orderAccess_linux_arm.hpp index 3784b640c2a..9e6bda2654f 100644 --- a/src/hotspot/os_cpu/linux_arm/orderAccess_linux_arm.inline.hpp +++ b/src/hotspot/os_cpu/linux_arm/orderAccess_linux_arm.hpp @@ -22,16 +22,17 @@ * */ -#ifndef OS_CPU_LINUX_ARM_VM_ORDERACCESS_LINUX_ARM_INLINE_HPP -#define OS_CPU_LINUX_ARM_VM_ORDERACCESS_LINUX_ARM_INLINE_HPP +#ifndef OS_CPU_LINUX_ARM_VM_ORDERACCESS_LINUX_ARM_HPP +#define OS_CPU_LINUX_ARM_VM_ORDERACCESS_LINUX_ARM_HPP + +// Included in orderAccess.hpp header file. -#include "runtime/orderAccess.hpp" #include "runtime/os.hpp" #include "vm_version_arm.hpp" // Implementation of class OrderAccess. // - we define the high level barriers below and use the general -// implementation in orderAccess.inline.hpp, with customizations +// implementation in orderAccess.hpp, with customizations // on AARCH64 via the specialized_* template functions // Memory Ordering on ARM is weak. @@ -53,7 +54,7 @@ // __asm__ volatile ( // "mcr p15, 0, %0, c7, c10, 4" // : : "r" (dummy) : "memory"); -// } +// } // } inline static void dmb_sy() { @@ -244,4 +245,4 @@ struct OrderAccess::PlatformOrderedStore<8, RELEASE_X_FENCE> #endif // AARCH64 -#endif // OS_CPU_LINUX_ARM_VM_ORDERACCESS_LINUX_ARM_INLINE_HPP +#endif // OS_CPU_LINUX_ARM_VM_ORDERACCESS_LINUX_ARM_HPP diff --git a/src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.inline.hpp b/src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.hpp similarity index 94% rename from src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.inline.hpp rename to src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.hpp index 12139ce2f7b..92ce8261fd2 100644 --- a/src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.inline.hpp +++ b/src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.hpp @@ -23,10 +23,10 @@ * */ -#ifndef OS_CPU_LINUX_PPC_VM_ORDERACCESS_LINUX_PPC_INLINE_HPP -#define OS_CPU_LINUX_PPC_VM_ORDERACCESS_LINUX_PPC_INLINE_HPP +#ifndef OS_CPU_LINUX_PPC_VM_ORDERACCESS_LINUX_PPC_HPP +#define OS_CPU_LINUX_PPC_VM_ORDERACCESS_LINUX_PPC_HPP -#include "runtime/orderAccess.hpp" +// Included in orderAccess.hpp header file. #ifndef PPC64 #error "OrderAccess currently only implemented for PPC64" @@ -94,4 +94,4 @@ struct OrderAccess::PlatformOrderedLoad #undef inlasm_isync #undef inlasm_acquire_reg -#endif // OS_CPU_LINUX_PPC_VM_ORDERACCESS_LINUX_PPC_INLINE_HPP +#endif // OS_CPU_LINUX_PPC_VM_ORDERACCESS_LINUX_PPC_HPP diff --git a/src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.inline.hpp b/src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.hpp similarity index 93% rename from src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.inline.hpp rename to src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.hpp index 067878501f6..daa13cec655 100644 --- a/src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.inline.hpp +++ b/src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.hpp @@ -23,10 +23,11 @@ * */ -#ifndef OS_CPU_LINUX_S390_VM_ORDERACCESS_LINUX_S390_INLINE_HPP -#define OS_CPU_LINUX_S390_VM_ORDERACCESS_LINUX_S390_INLINE_HPP +#ifndef OS_CPU_LINUX_S390_VM_ORDERACCESS_LINUX_S390_HPP +#define OS_CPU_LINUX_S390_VM_ORDERACCESS_LINUX_S390_HPP + +// Included in orderAccess.hpp header file. -#include "runtime/orderAccess.hpp" #include "vm_version_s390.hpp" // Implementation of class OrderAccess. @@ -87,4 +88,4 @@ struct OrderAccess::PlatformOrderedLoad #undef inlasm_zarch_acquire #undef inlasm_zarch_fence -#endif // OS_CPU_LINUX_S390_VM_ORDERACCESS_LINUX_S390_INLINE_HPP +#endif // OS_CPU_LINUX_S390_VM_ORDERACCESS_LINUX_S390_HPP diff --git a/src/hotspot/os_cpu/linux_sparc/orderAccess_linux_sparc.inline.hpp b/src/hotspot/os_cpu/linux_sparc/orderAccess_linux_sparc.hpp similarity index 85% rename from src/hotspot/os_cpu/linux_sparc/orderAccess_linux_sparc.inline.hpp rename to src/hotspot/os_cpu/linux_sparc/orderAccess_linux_sparc.hpp index c9fde925f7e..5ac28841849 100644 --- a/src/hotspot/os_cpu/linux_sparc/orderAccess_linux_sparc.inline.hpp +++ b/src/hotspot/os_cpu/linux_sparc/orderAccess_linux_sparc.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -22,10 +22,10 @@ * */ -#ifndef OS_CPU_LINUX_SPARC_VM_ORDERACCESS_LINUX_SPARC_INLINE_HPP -#define OS_CPU_LINUX_SPARC_VM_ORDERACCESS_LINUX_SPARC_INLINE_HPP +#ifndef OS_CPU_LINUX_SPARC_VM_ORDERACCESS_LINUX_SPARC_HPP +#define OS_CPU_LINUX_SPARC_VM_ORDERACCESS_LINUX_SPARC_HPP -#include "runtime/orderAccess.hpp" +// Included in orderAccess.hpp header file. // Implementation of class OrderAccess. @@ -48,4 +48,4 @@ inline void OrderAccess::fence() { __asm__ volatile ("membar #StoreLoad" : : : "memory"); } -#endif // OS_CPU_LINUX_SPARC_VM_ORDERACCESS_LINUX_SPARC_INLINE_HPP +#endif // OS_CPU_LINUX_SPARC_VM_ORDERACCESS_LINUX_SPARC_HPP diff --git a/src/hotspot/os_cpu/linux_x86/orderAccess_linux_x86.inline.hpp b/src/hotspot/os_cpu/linux_x86/orderAccess_linux_x86.hpp similarity index 85% rename from src/hotspot/os_cpu/linux_x86/orderAccess_linux_x86.inline.hpp rename to src/hotspot/os_cpu/linux_x86/orderAccess_linux_x86.hpp index 2a6d587a2ac..0cf302992c1 100644 --- a/src/hotspot/os_cpu/linux_x86/orderAccess_linux_x86.inline.hpp +++ b/src/hotspot/os_cpu/linux_x86/orderAccess_linux_x86.hpp @@ -22,12 +22,10 @@ * */ -#ifndef OS_CPU_LINUX_X86_VM_ORDERACCESS_LINUX_X86_INLINE_HPP -#define OS_CPU_LINUX_X86_VM_ORDERACCESS_LINUX_X86_INLINE_HPP +#ifndef OS_CPU_LINUX_X86_VM_ORDERACCESS_LINUX_X86_HPP +#define OS_CPU_LINUX_X86_VM_ORDERACCESS_LINUX_X86_HPP -#include "runtime/atomic.hpp" -#include "runtime/orderAccess.hpp" -#include "runtime/os.hpp" +// Included in orderAccess.hpp header file. // Compiler version last used for testing: gcc 4.8.2 // Please update this information when this file changes @@ -48,14 +46,12 @@ inline void OrderAccess::acquire() { compiler_barrier(); } inline void OrderAccess::release() { compiler_barrier(); } inline void OrderAccess::fence() { - if (os::is_MP()) { - // always use locked addl since mfence is sometimes expensive + // always use locked addl since mfence is sometimes expensive #ifdef AMD64 - __asm__ volatile ("lock; addl $0,0(%%rsp)" : : : "cc", "memory"); + __asm__ volatile ("lock; addl $0,0(%%rsp)" : : : "cc", "memory"); #else - __asm__ volatile ("lock; addl $0,0(%%esp)" : : : "cc", "memory"); + __asm__ volatile ("lock; addl $0,0(%%esp)" : : : "cc", "memory"); #endif - } compiler_barrier(); } @@ -109,4 +105,4 @@ struct OrderAccess::PlatformOrderedStore<8, RELEASE_X_FENCE> }; #endif // AMD64 -#endif // OS_CPU_LINUX_X86_VM_ORDERACCESS_LINUX_X86_INLINE_HPP +#endif // OS_CPU_LINUX_X86_VM_ORDERACCESS_LINUX_X86_HPP diff --git a/src/hotspot/os_cpu/linux_zero/orderAccess_linux_zero.inline.hpp b/src/hotspot/os_cpu/linux_zero/orderAccess_linux_zero.hpp similarity index 89% rename from src/hotspot/os_cpu/linux_zero/orderAccess_linux_zero.inline.hpp rename to src/hotspot/os_cpu/linux_zero/orderAccess_linux_zero.hpp index 8c4cd1c7a1c..950a4819f36 100644 --- a/src/hotspot/os_cpu/linux_zero/orderAccess_linux_zero.inline.hpp +++ b/src/hotspot/os_cpu/linux_zero/orderAccess_linux_zero.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2018, Oracle and/or its affiliates. All rights reserved. * Copyright 2007, 2008, 2009 Red Hat, Inc. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -23,10 +23,10 @@ * */ -#ifndef OS_CPU_LINUX_ZERO_VM_ORDERACCESS_LINUX_ZERO_INLINE_HPP -#define OS_CPU_LINUX_ZERO_VM_ORDERACCESS_LINUX_ZERO_INLINE_HPP +#ifndef OS_CPU_LINUX_ZERO_VM_ORDERACCESS_LINUX_ZERO_HPP +#define OS_CPU_LINUX_ZERO_VM_ORDERACCESS_LINUX_ZERO_HPP -#include "runtime/orderAccess.hpp" +// Included in orderAccess.hpp header file. #ifdef ARM @@ -83,4 +83,4 @@ inline void OrderAccess::release() { LIGHT_MEM_BARRIER; } inline void OrderAccess::fence() { FULL_MEM_BARRIER; } -#endif // OS_CPU_LINUX_ZERO_VM_ORDERACCESS_LINUX_ZERO_INLINE_HPP +#endif // OS_CPU_LINUX_ZERO_VM_ORDERACCESS_LINUX_ZERO_HPP diff --git a/src/hotspot/os_cpu/solaris_sparc/orderAccess_solaris_sparc.inline.hpp b/src/hotspot/os_cpu/solaris_sparc/orderAccess_solaris_sparc.hpp similarity index 84% rename from src/hotspot/os_cpu/solaris_sparc/orderAccess_solaris_sparc.inline.hpp rename to src/hotspot/os_cpu/solaris_sparc/orderAccess_solaris_sparc.hpp index b60cd092c50..14422eb1252 100644 --- a/src/hotspot/os_cpu/solaris_sparc/orderAccess_solaris_sparc.inline.hpp +++ b/src/hotspot/os_cpu/solaris_sparc/orderAccess_solaris_sparc.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -22,11 +22,10 @@ * */ -#ifndef OS_CPU_SOLARIS_SPARC_VM_ORDERACCESS_SOLARIS_SPARC_INLINE_HPP -#define OS_CPU_SOLARIS_SPARC_VM_ORDERACCESS_SOLARIS_SPARC_INLINE_HPP +#ifndef OS_CPU_SOLARIS_SPARC_VM_ORDERACCESS_SOLARIS_SPARC_HPP +#define OS_CPU_SOLARIS_SPARC_VM_ORDERACCESS_SOLARIS_SPARC_HPP -#include "runtime/atomic.hpp" -#include "runtime/orderAccess.hpp" +// Included in orderAccess.hpp header file. // Compiler version last used for testing: solaris studio 12u3 // Please update this information when this file changes @@ -52,4 +51,4 @@ inline void OrderAccess::fence() { __asm__ volatile ("membar #StoreLoad" : : : "memory"); } -#endif // OS_CPU_SOLARIS_SPARC_VM_ORDERACCESS_SOLARIS_SPARC_INLINE_HPP +#endif // OS_CPU_SOLARIS_SPARC_VM_ORDERACCESS_SOLARIS_SPARC_HPP diff --git a/src/hotspot/os_cpu/solaris_x86/orderAccess_solaris_x86.inline.hpp b/src/hotspot/os_cpu/solaris_x86/orderAccess_solaris_x86.hpp similarity index 77% rename from src/hotspot/os_cpu/solaris_x86/orderAccess_solaris_x86.inline.hpp rename to src/hotspot/os_cpu/solaris_x86/orderAccess_solaris_x86.hpp index bd676dbe62f..ad18c0f349c 100644 --- a/src/hotspot/os_cpu/solaris_x86/orderAccess_solaris_x86.inline.hpp +++ b/src/hotspot/os_cpu/solaris_x86/orderAccess_solaris_x86.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -22,12 +22,10 @@ * */ -#ifndef OS_CPU_SOLARIS_X86_VM_ORDERACCESS_SOLARIS_X86_INLINE_HPP -#define OS_CPU_SOLARIS_X86_VM_ORDERACCESS_SOLARIS_X86_INLINE_HPP +#ifndef OS_CPU_SOLARIS_X86_VM_ORDERACCESS_SOLARIS_X86_HPP +#define OS_CPU_SOLARIS_X86_VM_ORDERACCESS_SOLARIS_X86_HPP -#include "runtime/atomic.hpp" -#include "runtime/orderAccess.hpp" -#include "runtime/os.hpp" +// Included in orderAccess.hpp header file. // Compiler version last used for testing: solaris studio 12u3 // Please update this information when this file changes @@ -48,14 +46,12 @@ inline void OrderAccess::acquire() { compiler_barrier(); } inline void OrderAccess::release() { compiler_barrier(); } inline void OrderAccess::fence() { - if (os::is_MP()) { #ifdef AMD64 - __asm__ volatile ("lock; addl $0,0(%%rsp)" : : : "cc", "memory"); + __asm__ volatile ("lock; addl $0,0(%%rsp)" : : : "cc", "memory"); #else - __asm__ volatile ("lock; addl $0,0(%%esp)" : : : "cc", "memory"); + __asm__ volatile ("lock; addl $0,0(%%esp)" : : : "cc", "memory"); #endif - } compiler_barrier(); } -#endif // OS_CPU_SOLARIS_X86_VM_ORDERACCESS_SOLARIS_X86_INLINE_HPP +#endif // OS_CPU_SOLARIS_X86_VM_ORDERACCESS_SOLARIS_X86_HPP diff --git a/src/hotspot/os_cpu/windows_x86/orderAccess_windows_x86.inline.hpp b/src/hotspot/os_cpu/windows_x86/orderAccess_windows_x86.hpp similarity index 90% rename from src/hotspot/os_cpu/windows_x86/orderAccess_windows_x86.inline.hpp rename to src/hotspot/os_cpu/windows_x86/orderAccess_windows_x86.hpp index d2f39ee21bd..0f06f1b58bd 100644 --- a/src/hotspot/os_cpu/windows_x86/orderAccess_windows_x86.inline.hpp +++ b/src/hotspot/os_cpu/windows_x86/orderAccess_windows_x86.hpp @@ -22,13 +22,12 @@ * */ -#ifndef OS_CPU_WINDOWS_X86_VM_ORDERACCESS_WINDOWS_X86_INLINE_HPP -#define OS_CPU_WINDOWS_X86_VM_ORDERACCESS_WINDOWS_X86_INLINE_HPP +#ifndef OS_CPU_WINDOWS_X86_VM_ORDERACCESS_WINDOWS_X86_HPP +#define OS_CPU_WINDOWS_X86_VM_ORDERACCESS_WINDOWS_X86_HPP + +// Included in orderAccess.hpp header file. #include -#include "runtime/atomic.hpp" -#include "runtime/orderAccess.hpp" -#include "runtime/os.hpp" // Compiler version last used for testing: Microsoft Visual Studio 2010 // Please update this information when this file changes @@ -63,10 +62,8 @@ inline void OrderAccess::fence() { #ifdef AMD64 StubRoutines_fence(); #else - if (os::is_MP()) { - __asm { - lock add dword ptr [esp], 0; - } + __asm { + lock add dword ptr [esp], 0; } #endif // AMD64 compiler_barrier(); @@ -113,4 +110,4 @@ struct OrderAccess::PlatformOrderedStore<4, RELEASE_X_FENCE> }; #endif // AMD64 -#endif // OS_CPU_WINDOWS_X86_VM_ORDERACCESS_WINDOWS_X86_INLINE_HPP +#endif // OS_CPU_WINDOWS_X86_VM_ORDERACCESS_WINDOWS_X86_HPP diff --git a/src/hotspot/share/classfile/classLoader.inline.hpp b/src/hotspot/share/classfile/classLoader.inline.hpp index f32493d80bb..731dc0cb1e8 100644 --- a/src/hotspot/share/classfile/classLoader.inline.hpp +++ b/src/hotspot/share/classfile/classLoader.inline.hpp @@ -26,7 +26,7 @@ #define SHARE_VM_CLASSFILE_CLASSLOADER_INLINE_HPP #include "classfile/classLoader.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" // Next entry in class path inline ClassPathEntry* ClassPathEntry::next() const { return OrderAccess::load_acquire(&_next); } diff --git a/src/hotspot/share/classfile/dictionary.cpp b/src/hotspot/share/classfile/dictionary.cpp index db35510398d..b422bb68530 100644 --- a/src/hotspot/share/classfile/dictionary.cpp +++ b/src/hotspot/share/classfile/dictionary.cpp @@ -35,7 +35,7 @@ #include "memory/resourceArea.hpp" #include "oops/oop.inline.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/safepointVerifiers.hpp" #include "utilities/hashtable.inline.hpp" diff --git a/src/hotspot/share/classfile/dictionary.inline.hpp b/src/hotspot/share/classfile/dictionary.inline.hpp index 4a24fb00c78..4e1c73bbb5b 100644 --- a/src/hotspot/share/classfile/dictionary.inline.hpp +++ b/src/hotspot/share/classfile/dictionary.inline.hpp @@ -26,7 +26,7 @@ #define SHARE_VM_CLASSFILE_DICTIONARY_INLINE_HPP #include "classfile/dictionary.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" inline ProtectionDomainEntry* DictionaryEntry::pd_set_acquire() const { return OrderAccess::load_acquire(&_pd_set); diff --git a/src/hotspot/share/classfile/systemDictionary.cpp b/src/hotspot/share/classfile/systemDictionary.cpp index a2917941866..e8a99f00f70 100644 --- a/src/hotspot/share/classfile/systemDictionary.cpp +++ b/src/hotspot/share/classfile/systemDictionary.cpp @@ -76,7 +76,7 @@ #include "runtime/java.hpp" #include "runtime/javaCalls.hpp" #include "runtime/mutexLocker.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/sharedRuntime.hpp" #include "runtime/signature.hpp" #include "services/classLoadingService.hpp" diff --git a/src/hotspot/share/classfile/verifier.cpp b/src/hotspot/share/classfile/verifier.cpp index 8685f408417..2e76c0ecd95 100644 --- a/src/hotspot/share/classfile/verifier.cpp +++ b/src/hotspot/share/classfile/verifier.cpp @@ -47,7 +47,7 @@ #include "runtime/interfaceSupport.inline.hpp" #include "runtime/javaCalls.hpp" #include "runtime/jniHandles.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.hpp" #include "runtime/safepointVerifiers.hpp" #include "runtime/thread.hpp" diff --git a/src/hotspot/share/code/nmethod.cpp b/src/hotspot/share/code/nmethod.cpp index afe72d53508..98a7bdbeed3 100644 --- a/src/hotspot/share/code/nmethod.cpp +++ b/src/hotspot/share/code/nmethod.cpp @@ -51,7 +51,7 @@ #include "runtime/frame.inline.hpp" #include "runtime/handles.inline.hpp" #include "runtime/jniHandles.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.hpp" #include "runtime/safepointVerifiers.hpp" #include "runtime/sharedRuntime.hpp" diff --git a/src/hotspot/share/gc/cms/adaptiveFreeList.cpp b/src/hotspot/share/gc/cms/adaptiveFreeList.cpp index 753cc8a8dee..f0319ed6041 100644 --- a/src/hotspot/share/gc/cms/adaptiveFreeList.cpp +++ b/src/hotspot/share/gc/cms/adaptiveFreeList.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,7 +29,7 @@ #include "memory/freeList.inline.hpp" #include "runtime/globals.hpp" #include "runtime/mutex.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/vmThread.hpp" template <> diff --git a/src/hotspot/share/gc/cms/cmsCardTable.cpp b/src/hotspot/share/gc/cms/cmsCardTable.cpp index e0a96cf9daf..b823a079b2a 100644 --- a/src/hotspot/share/gc/cms/cmsCardTable.cpp +++ b/src/hotspot/share/gc/cms/cmsCardTable.cpp @@ -34,7 +34,7 @@ #include "oops/oop.inline.hpp" #include "runtime/java.hpp" #include "runtime/mutexLocker.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/vmThread.hpp" CMSCardTable::CMSCardTable(MemRegion whole_heap) : diff --git a/src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp b/src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp index 53b54cd3476..0b6c7c380fc 100644 --- a/src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp +++ b/src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp @@ -45,7 +45,7 @@ #include "runtime/handles.inline.hpp" #include "runtime/init.hpp" #include "runtime/java.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/vmThread.hpp" #include "utilities/align.hpp" #include "utilities/copy.hpp" diff --git a/src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp b/src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp index ca7cb2b042e..779bc201e10 100644 --- a/src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp +++ b/src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp @@ -74,7 +74,7 @@ #include "runtime/globals_extension.hpp" #include "runtime/handles.inline.hpp" #include "runtime/java.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/timer.hpp" #include "runtime/vmThread.hpp" #include "services/memoryService.hpp" diff --git a/src/hotspot/share/gc/g1/g1AllocRegion.cpp b/src/hotspot/share/gc/g1/g1AllocRegion.cpp index 73a5bdb6a11..174ddcd4e3f 100644 --- a/src/hotspot/share/gc/g1/g1AllocRegion.cpp +++ b/src/hotspot/share/gc/g1/g1AllocRegion.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2011, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2011, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,7 +29,7 @@ #include "logging/log.hpp" #include "logging/logStream.hpp" #include "memory/resourceArea.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "utilities/align.hpp" G1CollectedHeap* G1AllocRegion::_g1h = NULL; diff --git a/src/hotspot/share/gc/g1/g1CardTable.cpp b/src/hotspot/share/gc/g1/g1CardTable.cpp index 3a68f4a7c46..b66ddd28a5b 100644 --- a/src/hotspot/share/gc/g1/g1CardTable.cpp +++ b/src/hotspot/share/gc/g1/g1CardTable.cpp @@ -28,7 +28,7 @@ #include "gc/shared/memset_with_concurrent_readers.hpp" #include "logging/log.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" bool G1CardTable::mark_card_deferred(size_t card_index) { jbyte val = _byte_map[card_index]; diff --git a/src/hotspot/share/gc/g1/g1CollectedHeap.cpp b/src/hotspot/share/gc/g1/g1CollectedHeap.cpp index 8797e04bcf0..00954e6e940 100644 --- a/src/hotspot/share/gc/g1/g1CollectedHeap.cpp +++ b/src/hotspot/share/gc/g1/g1CollectedHeap.cpp @@ -86,7 +86,7 @@ #include "runtime/flags/flagSetting.hpp" #include "runtime/handles.inline.hpp" #include "runtime/init.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/threadSMR.hpp" #include "runtime/vmThread.hpp" #include "utilities/align.hpp" diff --git a/src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp b/src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp index afd5f5f19a0..30000fd5b34 100644 --- a/src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp +++ b/src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp @@ -32,7 +32,7 @@ #include "gc/g1/heapRegionManager.inline.hpp" #include "gc/g1/heapRegionSet.inline.hpp" #include "gc/shared/taskqueue.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" G1EvacStats* G1CollectedHeap::alloc_buffer_stats(InCSetState dest) { switch (dest.value()) { diff --git a/src/hotspot/share/gc/g1/heapRegion.cpp b/src/hotspot/share/gc/g1/heapRegion.cpp index 057e7cb4a67..783a4ebcbdb 100644 --- a/src/hotspot/share/gc/g1/heapRegion.cpp +++ b/src/hotspot/share/gc/g1/heapRegion.cpp @@ -43,7 +43,7 @@ #include "oops/compressedOops.inline.hpp" #include "oops/oop.inline.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "utilities/growableArray.hpp" int HeapRegion::LogOfHRGrainBytes = 0; diff --git a/src/hotspot/share/gc/parallel/gcTaskManager.cpp b/src/hotspot/share/gc/parallel/gcTaskManager.cpp index f01608626f9..54e706a3569 100644 --- a/src/hotspot/share/gc/parallel/gcTaskManager.cpp +++ b/src/hotspot/share/gc/parallel/gcTaskManager.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -34,7 +34,7 @@ #include "memory/resourceArea.hpp" #include "runtime/mutex.hpp" #include "runtime/mutexLocker.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.hpp" // diff --git a/src/hotspot/share/gc/shared/cardTableBarrierSet.inline.hpp b/src/hotspot/share/gc/shared/cardTableBarrierSet.inline.hpp index b0eb89bd342..b92f89399e3 100644 --- a/src/hotspot/share/gc/shared/cardTableBarrierSet.inline.hpp +++ b/src/hotspot/share/gc/shared/cardTableBarrierSet.inline.hpp @@ -27,7 +27,7 @@ #include "gc/shared/cardTableBarrierSet.hpp" #include "gc/shared/cardTable.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" template inline void CardTableBarrierSet::write_ref_field_post(T* field, oop newVal) { diff --git a/src/hotspot/share/gc/shared/oopStorage.cpp b/src/hotspot/share/gc/shared/oopStorage.cpp index 6416657c0bc..bbf94715e9c 100644 --- a/src/hotspot/share/gc/shared/oopStorage.cpp +++ b/src/hotspot/share/gc/shared/oopStorage.cpp @@ -33,7 +33,7 @@ #include "runtime/handles.inline.hpp" #include "runtime/mutex.hpp" #include "runtime/mutexLocker.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/safepoint.hpp" #include "runtime/stubRoutines.hpp" #include "runtime/thread.hpp" diff --git a/src/hotspot/share/gc/shared/space.cpp b/src/hotspot/share/gc/shared/space.cpp index 5fa1ec8cae1..b8659e57f63 100644 --- a/src/hotspot/share/gc/shared/space.cpp +++ b/src/hotspot/share/gc/shared/space.cpp @@ -36,7 +36,7 @@ #include "oops/oop.inline.hpp" #include "runtime/atomic.hpp" #include "runtime/java.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/prefetch.inline.hpp" #include "runtime/safepoint.hpp" #include "utilities/align.hpp" diff --git a/src/hotspot/share/gc/shared/taskqueue.inline.hpp b/src/hotspot/share/gc/shared/taskqueue.inline.hpp index 476098d57aa..214bb3f222f 100644 --- a/src/hotspot/share/gc/shared/taskqueue.inline.hpp +++ b/src/hotspot/share/gc/shared/taskqueue.inline.hpp @@ -29,7 +29,7 @@ #include "memory/allocation.inline.hpp" #include "oops/oop.inline.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "utilities/debug.hpp" #include "utilities/stack.inline.hpp" diff --git a/src/hotspot/share/interpreter/bytecodeInterpreter.cpp b/src/hotspot/share/interpreter/bytecodeInterpreter.cpp index cb8e6b4f44e..f11cccfaf33 100644 --- a/src/hotspot/share/interpreter/bytecodeInterpreter.cpp +++ b/src/hotspot/share/interpreter/bytecodeInterpreter.cpp @@ -49,7 +49,7 @@ #include "runtime/frame.inline.hpp" #include "runtime/handles.inline.hpp" #include "runtime/interfaceSupport.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/sharedRuntime.hpp" #include "runtime/threadCritical.hpp" #include "utilities/exceptions.hpp" diff --git a/src/hotspot/share/jfr/leakprofiler/leakProfiler.cpp b/src/hotspot/share/jfr/leakprofiler/leakProfiler.cpp index 468fe40cd47..875b79578f9 100644 --- a/src/hotspot/share/jfr/leakprofiler/leakProfiler.cpp +++ b/src/hotspot/share/jfr/leakprofiler/leakProfiler.cpp @@ -32,7 +32,7 @@ #include "memory/iterator.hpp" #include "oops/oop.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/thread.inline.hpp" #include "runtime/vmThread.hpp" #include "utilities/ostream.hpp" diff --git a/src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp b/src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp index 9ae40119f04..5fc07d443b0 100644 --- a/src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp +++ b/src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp @@ -38,7 +38,7 @@ #include "logging/log.hpp" #include "memory/resourceArea.hpp" #include "runtime/mutexLocker.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.inline.hpp" #include "runtime/safepoint.hpp" diff --git a/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.cpp b/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.cpp index 6df57f83832..1a838d1cecc 100644 --- a/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.cpp +++ b/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.cpp @@ -33,7 +33,7 @@ #include "oops/method.hpp" #include "oops/oop.inline.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/vm_version.hpp" #include "runtime/jniHandles.inline.hpp" #include "runtime/thread.inline.hpp" diff --git a/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.inline.hpp b/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.inline.hpp index 09460e888f1..fa7b273a2b9 100644 --- a/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.inline.hpp +++ b/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.inline.hpp @@ -27,7 +27,7 @@ #include "jfr/utilities/jfrTypes.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "utilities/macros.hpp" #ifdef VM_LITTLE_ENDIAN diff --git a/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdEpoch.cpp b/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdEpoch.cpp index b76a3046720..80c4b0ac175 100644 --- a/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdEpoch.cpp +++ b/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdEpoch.cpp @@ -25,7 +25,7 @@ #include "precompiled.hpp" #include "jfr/recorder/checkpoint/types/traceid/jfrTraceIdEpoch.hpp" #include "runtime/safepoint.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" // Alternating epochs on each rotation allow for concurrent tagging. // The regular epoch shift happens only during a safepoint. diff --git a/src/hotspot/share/jfr/recorder/service/jfrPostBox.cpp b/src/hotspot/share/jfr/recorder/service/jfrPostBox.cpp index aa67f97d7cb..cbc61605977 100644 --- a/src/hotspot/share/jfr/recorder/service/jfrPostBox.cpp +++ b/src/hotspot/share/jfr/recorder/service/jfrPostBox.cpp @@ -26,7 +26,7 @@ #include "jfr/recorder/service/jfrPostBox.hpp" #include "jfr/utilities/jfrTryLock.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/thread.inline.hpp" #define MSG_IS_SYNCHRONOUS ( (MSGBIT(MSG_ROTATE)) | \ diff --git a/src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp b/src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp index 63c56ff7124..512897ce886 100644 --- a/src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp +++ b/src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp @@ -46,7 +46,7 @@ #include "runtime/atomic.hpp" #include "runtime/handles.inline.hpp" #include "runtime/mutexLocker.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.hpp" #include "runtime/safepoint.hpp" #include "runtime/thread.inline.hpp" diff --git a/src/hotspot/share/jfr/recorder/storage/jfrBuffer.cpp b/src/hotspot/share/jfr/recorder/storage/jfrBuffer.cpp index a039d2747fb..4725707b2db 100644 --- a/src/hotspot/share/jfr/recorder/storage/jfrBuffer.cpp +++ b/src/hotspot/share/jfr/recorder/storage/jfrBuffer.cpp @@ -25,7 +25,7 @@ #include "precompiled.hpp" #include "jfr/recorder/storage/jfrBuffer.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/thread.inline.hpp" static const u1* const MUTEX_CLAIM = NULL; diff --git a/src/hotspot/share/jfr/recorder/storage/jfrStorage.cpp b/src/hotspot/share/jfr/recorder/storage/jfrStorage.cpp index 8e92f068227..7292c841658 100644 --- a/src/hotspot/share/jfr/recorder/storage/jfrStorage.cpp +++ b/src/hotspot/share/jfr/recorder/storage/jfrStorage.cpp @@ -38,7 +38,7 @@ #include "jfr/writers/jfrNativeEventWriter.hpp" #include "logging/log.hpp" #include "runtime/mutexLocker.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.inline.hpp" #include "runtime/safepoint.hpp" #include "runtime/thread.hpp" diff --git a/src/hotspot/share/jfr/recorder/storage/jfrStorageControl.cpp b/src/hotspot/share/jfr/recorder/storage/jfrStorageControl.cpp index 51eb7583691..a0f7c34d47a 100644 --- a/src/hotspot/share/jfr/recorder/storage/jfrStorageControl.cpp +++ b/src/hotspot/share/jfr/recorder/storage/jfrStorageControl.cpp @@ -26,7 +26,7 @@ #include "jfr/recorder/storage/jfrStorageControl.hpp" #include "runtime/atomic.hpp" #include "runtime/mutexLocker.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" // returns the updated value static jlong atomic_add(size_t value, size_t volatile* const dest) { diff --git a/src/hotspot/share/jfr/recorder/storage/jfrVirtualMemory.cpp b/src/hotspot/share/jfr/recorder/storage/jfrVirtualMemory.cpp index 9e76aac7126..ea282328f2c 100644 --- a/src/hotspot/share/jfr/recorder/storage/jfrVirtualMemory.cpp +++ b/src/hotspot/share/jfr/recorder/storage/jfrVirtualMemory.cpp @@ -25,7 +25,7 @@ #include "precompiled.hpp" #include "jfr/recorder/storage/jfrVirtualMemory.hpp" #include "memory/virtualspace.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.hpp" #include "services/memTracker.hpp" #include "utilities/globalDefinitions.hpp" diff --git a/src/hotspot/share/jfr/recorder/stringpool/jfrStringPool.cpp b/src/hotspot/share/jfr/recorder/stringpool/jfrStringPool.cpp index 549bbab9343..a5de4d12209 100644 --- a/src/hotspot/share/jfr/recorder/stringpool/jfrStringPool.cpp +++ b/src/hotspot/share/jfr/recorder/stringpool/jfrStringPool.cpp @@ -35,7 +35,7 @@ #include "logging/log.hpp" #include "runtime/atomic.hpp" #include "runtime/mutexLocker.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/safepoint.hpp" #include "runtime/thread.inline.hpp" diff --git a/src/hotspot/share/jfr/recorder/stringpool/jfrStringPoolBuffer.cpp b/src/hotspot/share/jfr/recorder/stringpool/jfrStringPoolBuffer.cpp index 4e0edc7c8c0..f5f95b976be 100644 --- a/src/hotspot/share/jfr/recorder/stringpool/jfrStringPoolBuffer.cpp +++ b/src/hotspot/share/jfr/recorder/stringpool/jfrStringPoolBuffer.cpp @@ -25,7 +25,7 @@ #include "precompiled.hpp" #include "jfr/recorder/stringpool/jfrStringPoolBuffer.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/thread.inline.hpp" JfrStringPoolBuffer::JfrStringPoolBuffer() : JfrBuffer(), _string_count_pos(0), _string_count_top(0) {} diff --git a/src/hotspot/share/jfr/utilities/jfrAllocation.cpp b/src/hotspot/share/jfr/utilities/jfrAllocation.cpp index fa5366ecdbf..b50db7c5dac 100644 --- a/src/hotspot/share/jfr/utilities/jfrAllocation.cpp +++ b/src/hotspot/share/jfr/utilities/jfrAllocation.cpp @@ -28,7 +28,7 @@ #include "logging/log.hpp" #include "memory/allocation.inline.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/vm_version.hpp" #include "utilities/debug.hpp" #include "utilities/macros.hpp" diff --git a/src/hotspot/share/jfr/utilities/jfrHashtable.hpp b/src/hotspot/share/jfr/utilities/jfrHashtable.hpp index 1aa4dbde599..ea025c2ced1 100644 --- a/src/hotspot/share/jfr/utilities/jfrHashtable.hpp +++ b/src/hotspot/share/jfr/utilities/jfrHashtable.hpp @@ -26,7 +26,7 @@ #define SHARE_VM_JFR_UTILITIES_JFRHASHTABLE_HPP #include "memory/allocation.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "utilities/debug.hpp" #include "utilities/macros.hpp" diff --git a/src/hotspot/share/logging/logOutputList.cpp b/src/hotspot/share/logging/logOutputList.cpp index bc0565ae766..00985fc9ad4 100644 --- a/src/hotspot/share/logging/logOutputList.cpp +++ b/src/hotspot/share/logging/logOutputList.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -26,7 +26,7 @@ #include "logging/logOutputList.hpp" #include "memory/allocation.inline.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "utilities/globalDefinitions.hpp" jint LogOutputList::increase_readers() { diff --git a/src/hotspot/share/memory/metaspace.cpp b/src/hotspot/share/memory/metaspace.cpp index ed451839d68..40ff2c7091c 100644 --- a/src/hotspot/share/memory/metaspace.cpp +++ b/src/hotspot/share/memory/metaspace.cpp @@ -40,7 +40,7 @@ #include "memory/metaspaceTracer.hpp" #include "memory/universe.hpp" #include "runtime/init.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "services/memTracker.hpp" #include "utilities/copy.hpp" #include "utilities/debug.hpp" diff --git a/src/hotspot/share/memory/metaspace/virtualSpaceList.cpp b/src/hotspot/share/memory/metaspace/virtualSpaceList.cpp index 210b3353fb6..6fc6054cb83 100644 --- a/src/hotspot/share/memory/metaspace/virtualSpaceList.cpp +++ b/src/hotspot/share/memory/metaspace/virtualSpaceList.cpp @@ -15,7 +15,7 @@ #include "memory/metaspace/metaspaceCommon.hpp" #include "memory/metaspace/virtualSpaceList.hpp" #include "memory/metaspace/virtualSpaceNode.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/mutexLocker.hpp" #include "runtime/safepoint.hpp" diff --git a/src/hotspot/share/oops/array.inline.hpp b/src/hotspot/share/oops/array.inline.hpp index 911f39aa9a0..e13086adb23 100644 --- a/src/hotspot/share/oops/array.inline.hpp +++ b/src/hotspot/share/oops/array.inline.hpp @@ -26,7 +26,7 @@ #define SHARE_VM_OOPS_ARRAY_INLINE_HPP #include "oops/array.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" template inline T Array::at_acquire(const int which) { return OrderAccess::load_acquire(adr_at(which)); } diff --git a/src/hotspot/share/oops/arrayKlass.inline.hpp b/src/hotspot/share/oops/arrayKlass.inline.hpp index f0a62bfb966..6caaae05de4 100644 --- a/src/hotspot/share/oops/arrayKlass.inline.hpp +++ b/src/hotspot/share/oops/arrayKlass.inline.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,7 +25,7 @@ #ifndef SHARE_VM_OOPS_ARRAYKLASS_INLINE_HPP #define SHARE_VM_OOPS_ARRAYKLASS_INLINE_HPP -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "oops/arrayKlass.hpp" inline Klass* ArrayKlass::higher_dimension_acquire() const { diff --git a/src/hotspot/share/oops/constantPool.inline.hpp b/src/hotspot/share/oops/constantPool.inline.hpp index da858be3de8..43aaa460c95 100644 --- a/src/hotspot/share/oops/constantPool.inline.hpp +++ b/src/hotspot/share/oops/constantPool.inline.hpp @@ -27,7 +27,7 @@ #include "oops/constantPool.hpp" #include "oops/cpCache.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" inline CPSlot ConstantPool::slot_at(int which) const { assert(is_within_bounds(which), "index out of bounds"); diff --git a/src/hotspot/share/oops/cpCache.cpp b/src/hotspot/share/oops/cpCache.cpp index be39ed70aac..d8ebf86cdda 100644 --- a/src/hotspot/share/oops/cpCache.cpp +++ b/src/hotspot/share/oops/cpCache.cpp @@ -42,7 +42,7 @@ #include "prims/methodHandles.hpp" #include "runtime/atomic.hpp" #include "runtime/handles.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "utilities/macros.hpp" // Implementation of ConstantPoolCacheEntry diff --git a/src/hotspot/share/oops/cpCache.inline.hpp b/src/hotspot/share/oops/cpCache.inline.hpp index f91a55d736f..c876e669de3 100644 --- a/src/hotspot/share/oops/cpCache.inline.hpp +++ b/src/hotspot/share/oops/cpCache.inline.hpp @@ -27,7 +27,7 @@ #include "oops/cpCache.hpp" #include "oops/oopHandle.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" inline int ConstantPoolCacheEntry::indices_ord() const { return OrderAccess::load_acquire(&_indices); } diff --git a/src/hotspot/share/oops/instanceKlass.cpp b/src/hotspot/share/oops/instanceKlass.cpp index 1935a702b01..204f37b4652 100644 --- a/src/hotspot/share/oops/instanceKlass.cpp +++ b/src/hotspot/share/oops/instanceKlass.cpp @@ -71,7 +71,7 @@ #include "runtime/handles.inline.hpp" #include "runtime/javaCalls.hpp" #include "runtime/mutexLocker.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/thread.inline.hpp" #include "services/classLoadingService.hpp" #include "services/threadService.hpp" diff --git a/src/hotspot/share/oops/instanceKlass.inline.hpp b/src/hotspot/share/oops/instanceKlass.inline.hpp index 745dcac9094..755ebcf06e2 100644 --- a/src/hotspot/share/oops/instanceKlass.inline.hpp +++ b/src/hotspot/share/oops/instanceKlass.inline.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,7 +29,7 @@ #include "oops/instanceKlass.hpp" #include "oops/klass.hpp" #include "oops/oop.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "utilities/debug.hpp" #include "utilities/globalDefinitions.hpp" #include "utilities/macros.hpp" diff --git a/src/hotspot/share/oops/klass.cpp b/src/hotspot/share/oops/klass.cpp index 2921fadab8c..42a02d68299 100644 --- a/src/hotspot/share/oops/klass.cpp +++ b/src/hotspot/share/oops/klass.cpp @@ -43,7 +43,7 @@ #include "oops/oopHandle.inline.hpp" #include "runtime/atomic.hpp" #include "runtime/handles.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "utilities/macros.hpp" #include "utilities/stack.inline.hpp" diff --git a/src/hotspot/share/oops/method.cpp b/src/hotspot/share/oops/method.cpp index 3eae5900eb2..83c8c88c71c 100644 --- a/src/hotspot/share/oops/method.cpp +++ b/src/hotspot/share/oops/method.cpp @@ -54,7 +54,7 @@ #include "runtime/frame.inline.hpp" #include "runtime/handles.inline.hpp" #include "runtime/init.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/relocator.hpp" #include "runtime/safepointVerifiers.hpp" #include "runtime/sharedRuntime.hpp" diff --git a/src/hotspot/share/oops/method.inline.hpp b/src/hotspot/share/oops/method.inline.hpp index a2837192842..490d22d3efd 100644 --- a/src/hotspot/share/oops/method.inline.hpp +++ b/src/hotspot/share/oops/method.inline.hpp @@ -26,7 +26,7 @@ #define SHARE_VM_OOPS_METHOD_INLINE_HPP #include "oops/method.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" inline address Method::from_compiled_entry() const { return OrderAccess::load_acquire(&_from_compiled_entry); diff --git a/src/hotspot/share/oops/methodData.cpp b/src/hotspot/share/oops/methodData.cpp index 01566424643..52b31451934 100644 --- a/src/hotspot/share/oops/methodData.cpp +++ b/src/hotspot/share/oops/methodData.cpp @@ -37,7 +37,7 @@ #include "runtime/compilationPolicy.hpp" #include "runtime/deoptimization.hpp" #include "runtime/handles.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/safepointVerifiers.hpp" #include "utilities/align.hpp" #include "utilities/copy.hpp" diff --git a/src/hotspot/share/oops/methodData.inline.hpp b/src/hotspot/share/oops/methodData.inline.hpp index d3a8a739f72..4be1830de27 100644 --- a/src/hotspot/share/oops/methodData.inline.hpp +++ b/src/hotspot/share/oops/methodData.inline.hpp @@ -26,7 +26,7 @@ #define SHARE_VM_OOPS_METHODDATA_INLINE_HPP #include "oops/methodData.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" inline void DataLayout::release_set_cell_at(int index, intptr_t value) { OrderAccess::release_store(&_cells[index], value); diff --git a/src/hotspot/share/oops/oop.inline.hpp b/src/hotspot/share/oops/oop.inline.hpp index b70c044be38..4d1e4b58e72 100644 --- a/src/hotspot/share/oops/oop.inline.hpp +++ b/src/hotspot/share/oops/oop.inline.hpp @@ -35,7 +35,7 @@ #include "oops/markOop.inline.hpp" #include "oops/oop.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.hpp" #include "utilities/align.hpp" #include "utilities/macros.hpp" diff --git a/src/hotspot/share/precompiled/precompiled.hpp b/src/hotspot/share/precompiled/precompiled.hpp index 605f30ff3f1..a0a99028b95 100644 --- a/src/hotspot/share/precompiled/precompiled.hpp +++ b/src/hotspot/share/precompiled/precompiled.hpp @@ -187,7 +187,7 @@ # include "runtime/mutexLocker.hpp" # include "runtime/objectMonitor.hpp" # include "runtime/orderAccess.hpp" -# include "runtime/orderAccess.inline.hpp" +# include "runtime/orderAccess.hpp" # include "runtime/os.hpp" # include "runtime/osThread.hpp" # include "runtime/perfData.hpp" diff --git a/src/hotspot/share/prims/jni.cpp b/src/hotspot/share/prims/jni.cpp index 64deba4ced8..1c8edde245f 100644 --- a/src/hotspot/share/prims/jni.cpp +++ b/src/hotspot/share/prims/jni.cpp @@ -73,7 +73,7 @@ #include "runtime/javaCalls.hpp" #include "runtime/jfieldIDWorkaround.hpp" #include "runtime/jniHandles.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/reflection.hpp" #include "runtime/safepointVerifiers.hpp" #include "runtime/sharedRuntime.hpp" diff --git a/src/hotspot/share/prims/jvm.cpp b/src/hotspot/share/prims/jvm.cpp index d526ee70675..9c5f49cf173 100644 --- a/src/hotspot/share/prims/jvm.cpp +++ b/src/hotspot/share/prims/jvm.cpp @@ -64,7 +64,7 @@ #include "runtime/javaCalls.hpp" #include "runtime/jfieldIDWorkaround.hpp" #include "runtime/jniHandles.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.inline.hpp" #include "runtime/perfData.hpp" #include "runtime/reflection.hpp" diff --git a/src/hotspot/share/prims/jvmtiRawMonitor.cpp b/src/hotspot/share/prims/jvmtiRawMonitor.cpp index 689ecbfa998..b9de34b9ba1 100644 --- a/src/hotspot/share/prims/jvmtiRawMonitor.cpp +++ b/src/hotspot/share/prims/jvmtiRawMonitor.cpp @@ -27,7 +27,7 @@ #include "prims/jvmtiRawMonitor.hpp" #include "runtime/atomic.hpp" #include "runtime/interfaceSupport.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/thread.inline.hpp" GrowableArray *JvmtiPendingMonitors::_monitors = new (ResourceObj::C_HEAP, mtInternal) GrowableArray(1,true); diff --git a/src/hotspot/share/prims/unsafe.cpp b/src/hotspot/share/prims/unsafe.cpp index 8b437b2b0d0..106b3cff8ff 100644 --- a/src/hotspot/share/prims/unsafe.cpp +++ b/src/hotspot/share/prims/unsafe.cpp @@ -40,7 +40,7 @@ #include "runtime/globals.hpp" #include "runtime/interfaceSupport.inline.hpp" #include "runtime/jniHandles.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/reflection.hpp" #include "runtime/thread.hpp" #include "runtime/threadSMR.hpp" diff --git a/src/hotspot/share/runtime/interfaceSupport.cpp b/src/hotspot/share/runtime/interfaceSupport.cpp index e1333bc811a..77777338157 100644 --- a/src/hotspot/share/runtime/interfaceSupport.cpp +++ b/src/hotspot/share/runtime/interfaceSupport.cpp @@ -31,7 +31,7 @@ #include "runtime/handles.inline.hpp" #include "runtime/init.hpp" #include "runtime/interfaceSupport.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.inline.hpp" #include "runtime/thread.inline.hpp" #include "runtime/safepointVerifiers.hpp" diff --git a/src/hotspot/share/runtime/mutex.cpp b/src/hotspot/share/runtime/mutex.cpp index 71de11470f9..379db487c72 100644 --- a/src/hotspot/share/runtime/mutex.cpp +++ b/src/hotspot/share/runtime/mutex.cpp @@ -26,7 +26,7 @@ #include "runtime/atomic.hpp" #include "runtime/interfaceSupport.inline.hpp" #include "runtime/mutex.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/osThread.hpp" #include "runtime/safepointMechanism.inline.hpp" #include "runtime/thread.inline.hpp" diff --git a/src/hotspot/share/runtime/objectMonitor.cpp b/src/hotspot/share/runtime/objectMonitor.cpp index 29b557d4445..f069d415edc 100644 --- a/src/hotspot/share/runtime/objectMonitor.cpp +++ b/src/hotspot/share/runtime/objectMonitor.cpp @@ -36,7 +36,7 @@ #include "runtime/mutexLocker.hpp" #include "runtime/objectMonitor.hpp" #include "runtime/objectMonitor.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/osThread.hpp" #include "runtime/safepointMechanism.inline.hpp" #include "runtime/sharedRuntime.hpp" diff --git a/src/hotspot/share/runtime/orderAccess.hpp b/src/hotspot/share/runtime/orderAccess.hpp index cae137f5f97..e7966593e7d 100644 --- a/src/hotspot/share/runtime/orderAccess.hpp +++ b/src/hotspot/share/runtime/orderAccess.hpp @@ -27,6 +27,7 @@ #include "memory/allocation.hpp" #include "runtime/atomic.hpp" +#include "utilities/macros.hpp" // Memory Access Ordering Model // @@ -311,4 +312,38 @@ struct OrderAccess::PlatformOrderedLoad { } }; +#include OS_CPU_HEADER(orderAccess) + +template<> inline void ScopedFenceGeneral::postfix() { OrderAccess::acquire(); } +template<> inline void ScopedFenceGeneral::prefix() { OrderAccess::release(); } +template<> inline void ScopedFenceGeneral::prefix() { OrderAccess::release(); } +template<> inline void ScopedFenceGeneral::postfix() { OrderAccess::fence(); } + + +template +inline void OrderAccess::ordered_store(volatile FieldType* p, FieldType v) { + ScopedFence f((void*)p); + Atomic::store(v, p); +} + +template +inline FieldType OrderAccess::ordered_load(const volatile FieldType* p) { + ScopedFence f((void*)p); + return Atomic::load(p); +} + +template +inline T OrderAccess::load_acquire(const volatile T* p) { + return LoadImpl >()(p); +} + +template +inline void OrderAccess::release_store(volatile D* p, T v) { + StoreImpl >()(v, p); +} + +template +inline void OrderAccess::release_store_fence(volatile D* p, T v) { + StoreImpl >()(v, p); +} #endif // SHARE_VM_RUNTIME_ORDERACCESS_HPP diff --git a/src/hotspot/share/runtime/orderAccess.inline.hpp b/src/hotspot/share/runtime/orderAccess.inline.hpp deleted file mode 100644 index b1c50bb3abb..00000000000 --- a/src/hotspot/share/runtime/orderAccess.inline.hpp +++ /dev/null @@ -1,66 +0,0 @@ -/* - * Copyright (c) 2014, 2017, Oracle and/or its affiliates. All rights reserved. - * Copyright (c) 2014, 2016 SAP SE. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - * - */ - -#ifndef SHARE_VM_RUNTIME_ORDERACCESS_INLINE_HPP -#define SHARE_VM_RUNTIME_ORDERACCESS_INLINE_HPP - -#include "runtime/orderAccess.hpp" -#include "utilities/macros.hpp" - -#include OS_CPU_HEADER_INLINE(orderAccess) - -template<> inline void ScopedFenceGeneral::postfix() { OrderAccess::acquire(); } -template<> inline void ScopedFenceGeneral::prefix() { OrderAccess::release(); } -template<> inline void ScopedFenceGeneral::prefix() { OrderAccess::release(); } -template<> inline void ScopedFenceGeneral::postfix() { OrderAccess::fence(); } - - -template -inline void OrderAccess::ordered_store(volatile FieldType* p, FieldType v) { - ScopedFence f((void*)p); - Atomic::store(v, p); -} - -template -inline FieldType OrderAccess::ordered_load(const volatile FieldType* p) { - ScopedFence f((void*)p); - return Atomic::load(p); -} - -template -inline T OrderAccess::load_acquire(const volatile T* p) { - return LoadImpl >()(p); -} - -template -inline void OrderAccess::release_store(volatile D* p, T v) { - StoreImpl >()(v, p); -} - -template -inline void OrderAccess::release_store_fence(volatile D* p, T v) { - StoreImpl >()(v, p); -} -#endif // SHARE_VM_RUNTIME_ORDERACCESS_INLINE_HPP diff --git a/src/hotspot/share/runtime/perfMemory.cpp b/src/hotspot/share/runtime/perfMemory.cpp index a0b5014ff57..02e62ff6339 100644 --- a/src/hotspot/share/runtime/perfMemory.cpp +++ b/src/hotspot/share/runtime/perfMemory.cpp @@ -30,7 +30,7 @@ #include "runtime/java.hpp" #include "runtime/mutex.hpp" #include "runtime/mutexLocker.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.hpp" #include "runtime/perfData.hpp" #include "runtime/perfMemory.hpp" diff --git a/src/hotspot/share/runtime/safepoint.cpp b/src/hotspot/share/runtime/safepoint.cpp index df659074fd7..da837a87cdb 100644 --- a/src/hotspot/share/runtime/safepoint.cpp +++ b/src/hotspot/share/runtime/safepoint.cpp @@ -50,7 +50,7 @@ #include "runtime/frame.inline.hpp" #include "runtime/interfaceSupport.inline.hpp" #include "runtime/mutexLocker.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/osThread.hpp" #include "runtime/safepoint.hpp" #include "runtime/safepointMechanism.inline.hpp" diff --git a/src/hotspot/share/runtime/sweeper.cpp b/src/hotspot/share/runtime/sweeper.cpp index 9e07ce1afe2..ae2d95d2a3e 100644 --- a/src/hotspot/share/runtime/sweeper.cpp +++ b/src/hotspot/share/runtime/sweeper.cpp @@ -38,7 +38,7 @@ #include "runtime/compilationPolicy.hpp" #include "runtime/interfaceSupport.inline.hpp" #include "runtime/mutexLocker.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.hpp" #include "runtime/sweeper.hpp" #include "runtime/thread.inline.hpp" diff --git a/src/hotspot/share/runtime/thread.cpp b/src/hotspot/share/runtime/thread.cpp index 6bc42f04a29..9c25a047e59 100644 --- a/src/hotspot/share/runtime/thread.cpp +++ b/src/hotspot/share/runtime/thread.cpp @@ -80,7 +80,7 @@ #include "runtime/memprofiler.hpp" #include "runtime/mutexLocker.hpp" #include "runtime/objectMonitor.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/osThread.hpp" #include "runtime/prefetch.inline.hpp" #include "runtime/safepoint.hpp" diff --git a/src/hotspot/share/runtime/thread.inline.hpp b/src/hotspot/share/runtime/thread.inline.hpp index b02e91368c2..33efd7c2749 100644 --- a/src/hotspot/share/runtime/thread.inline.hpp +++ b/src/hotspot/share/runtime/thread.inline.hpp @@ -27,7 +27,7 @@ #include "runtime/atomic.hpp" #include "runtime/globals.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.inline.hpp" #include "runtime/thread.hpp" diff --git a/src/hotspot/share/services/memTracker.cpp b/src/hotspot/share/services/memTracker.cpp index 21eaa4a9904..58aaff8aea3 100644 --- a/src/hotspot/share/services/memTracker.cpp +++ b/src/hotspot/share/services/memTracker.cpp @@ -25,7 +25,7 @@ #include "jvm.h" #include "runtime/mutex.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/vmThread.hpp" #include "runtime/vm_operations.hpp" #include "services/memBaseline.hpp" diff --git a/src/hotspot/share/services/memoryManager.cpp b/src/hotspot/share/services/memoryManager.cpp index ecf89e6b902..933fd78bb33 100644 --- a/src/hotspot/share/services/memoryManager.cpp +++ b/src/hotspot/share/services/memoryManager.cpp @@ -29,7 +29,7 @@ #include "oops/oop.inline.hpp" #include "runtime/handles.inline.hpp" #include "runtime/javaCalls.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "services/lowMemoryDetector.hpp" #include "services/management.hpp" #include "services/memoryManager.hpp" diff --git a/src/hotspot/share/services/memoryPool.cpp b/src/hotspot/share/services/memoryPool.cpp index 41b8221e14e..89b8f5e3eec 100644 --- a/src/hotspot/share/services/memoryPool.cpp +++ b/src/hotspot/share/services/memoryPool.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,7 +29,7 @@ #include "oops/oop.inline.hpp" #include "runtime/handles.inline.hpp" #include "runtime/javaCalls.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "services/lowMemoryDetector.hpp" #include "services/management.hpp" #include "services/memoryManager.hpp" diff --git a/src/hotspot/share/utilities/concurrentHashTable.inline.hpp b/src/hotspot/share/utilities/concurrentHashTable.inline.hpp index 4b7e4bdb2cd..089cd79c5e7 100644 --- a/src/hotspot/share/utilities/concurrentHashTable.inline.hpp +++ b/src/hotspot/share/utilities/concurrentHashTable.inline.hpp @@ -27,7 +27,7 @@ #include "memory/allocation.inline.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/prefetch.inline.hpp" #include "utilities/concurrentHashTable.hpp" #include "utilities/globalCounter.inline.hpp" diff --git a/src/hotspot/share/utilities/globalCounter.cpp b/src/hotspot/share/utilities/globalCounter.cpp index 75a4439dc63..30fa4063f35 100644 --- a/src/hotspot/share/utilities/globalCounter.cpp +++ b/src/hotspot/share/utilities/globalCounter.cpp @@ -24,7 +24,7 @@ #include "precompiled.hpp" #include "utilities/globalCounter.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/thread.hpp" #include "runtime/threadSMR.inline.hpp" #include "runtime/vmThread.hpp" diff --git a/src/hotspot/share/utilities/globalCounter.inline.hpp b/src/hotspot/share/utilities/globalCounter.inline.hpp index 29f140d0c48..f06b4924a5b 100644 --- a/src/hotspot/share/utilities/globalCounter.inline.hpp +++ b/src/hotspot/share/utilities/globalCounter.inline.hpp @@ -25,7 +25,7 @@ #ifndef SHARE_UTILITIES_GLOBAL_COUNTER_INLINE_HPP #define SHARE_UTILITIES_GLOBAL_COUNTER_INLINE_HPP -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/thread.inline.hpp" #include "utilities/globalCounter.hpp" diff --git a/src/hotspot/share/utilities/hashtable.inline.hpp b/src/hotspot/share/utilities/hashtable.inline.hpp index 17ab8d89f4f..6f06d1f6879 100644 --- a/src/hotspot/share/utilities/hashtable.inline.hpp +++ b/src/hotspot/share/utilities/hashtable.inline.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -26,7 +26,7 @@ #define SHARE_VM_UTILITIES_HASHTABLE_INLINE_HPP #include "memory/allocation.inline.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "utilities/hashtable.hpp" #include "utilities/dtrace.hpp" diff --git a/test/hotspot/gtest/utilities/test_globalCounter.cpp b/test/hotspot/gtest/utilities/test_globalCounter.cpp index 52ad41b654b..d6edb3d2246 100644 --- a/test/hotspot/gtest/utilities/test_globalCounter.cpp +++ b/test/hotspot/gtest/utilities/test_globalCounter.cpp @@ -23,7 +23,7 @@ #include "precompiled.hpp" #include "runtime/atomic.hpp" -#include "runtime/orderAccess.inline.hpp" +#include "runtime/orderAccess.hpp" #include "runtime/os.hpp" #include "utilities/globalCounter.hpp" #include "utilities/globalCounter.inline.hpp"