Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead. #1016

Closed
amosfolz opened this issue Jul 10, 2019 · 5 comments

Comments

@amosfolz
Copy link
Contributor

commented Jul 10, 2019

Not sure if this is already documented somewhere else... Here is dependency tree for abandoned guzzle/guzzle.

userfrosting/userfrosting
└── thephpleague/flysystem-rackspace
          └── rackspace/php-opencloud (WILL NOT BE UPDATED)
                  └── guzzle/guzzle (abandoned)

rackspace/php-opencloud has already expressed they will not be updating to guzzlehttp/guzzle and suggest to use php-opencloud/open-stack instead. So it comes down to whether or not thephpleague/flysystem-rackspace will be updated to use this or not.

@lcharette

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

I believe this is already fixed in develop with the great dependencies update. To confirm...

@lcharette lcharette added this to the 4.3.0 milestone Jul 10, 2019

@amosfolz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

I believe this is already fixed in develop with the great dependencies update. To confirm...

See here.

@lcharette

This comment has been minimized.

Copy link
Member

commented Jul 13, 2019

Oh you're right, the warning is still there... :/

@lcharette

This comment has been minimized.

Copy link
Member

commented Jul 13, 2019

Question now is why do we require league/flysystem-rackspace ... Apparently it's for the Filesystem service. Laravel doc still says to use that dependency... https://laravel.com/docs/5.8/filesystem#driver-prerequisites

@lcharette

This comment has been minimized.

Copy link
Member

commented Jul 13, 2019

Since rackspace might not be a popular choice, one thing we could do is remove that dependency and change the doc so anyone requiring rackspace storage have to add this dependency to their sprinkle.

Could probably do the same with S3...?

* Supported Drivers for disk: "local", "ftp", "sftp", "s3", "rackspace"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.