Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`handlebars-helpers.js` is in the wrong sprinkle #897

Closed
lcharette opened this issue Sep 29, 2018 · 0 comments

Comments

@lcharette
Copy link
Member

commented Sep 29, 2018

moment.js is required by the admin sprinkle... handlebars-helpers.js uses moment.js... handlebars-helpers.js is only defined in the admin sprinkle asset bundle... but handlebars-helpers.js is physically in the core sprinkle...

So if admin is not loaded, this file in core won't work.

Need to place that where it should belong...

@lcharette lcharette added this to the 4.1.20 milestone Sep 29, 2018

@lcharette lcharette self-assigned this Sep 29, 2018

@lcharette lcharette added this to Malou's Todo List in 4.2 Roadmap Sep 29, 2018

@lcharette lcharette modified the milestones: 4.1.x, 4.3.0 Jan 9, 2019

lcharette added a commit that referenced this issue Jul 13, 2019

@lcharette lcharette closed this Jul 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.