Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Model.php #1012

Merged

Conversation

@amosfolz
Copy link
Contributor

commented Jul 6, 2019

Change so postgreSQL (and other DB) will be case insensitive.

Issue #881

Update Model.php
Change so postgreSQL (and others) will be case insensitive
@codecov

This comment has been minimized.

Copy link

commented Jul 6, 2019

Codecov Report

Merging #1012 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1012   +/-   ##
==========================================
  Coverage      66.93%   66.93%           
  Complexity      1913     1913           
==========================================
  Files            159      159           
  Lines           6684     6684           
==========================================
  Hits            4474     4474           
  Misses          2210     2210
Impacted Files Coverage Δ Complexity Δ
app/sprinkles/core/src/Database/Models/Model.php 69.69% <100%> (ø) 10 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37a4a15...61da177. Read the comment docs.

@lcharette lcharette self-assigned this Jul 6, 2019

@lcharette lcharette added this to the 4.3.0 milestone Jul 6, 2019

@lcharette lcharette merged commit 3574750 into userfrosting:develop Jul 6, 2019

4 checks passed

codecov/patch 100% of diff hit (target 66.93%)
Details
codecov/project 66.93% (+0%) compared to 37a4a15
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@amosfolz amosfolz deleted the amosfolz:develop-caseInsensitive-findUnique branch Jul 6, 2019

@lcharette lcharette referenced this pull request Jul 13, 2019

Closed

Email is case-sensitive #881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.