Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AdminLTE to 2.4.15 #1015

Merged
merged 10 commits into from Jul 17, 2019

Conversation

@amosfolz
Copy link
Contributor

commented Jul 7, 2019

Will need help identifying if anything in AdminLTE-custom.js that I removed is actually still needed. (As far as I can tell, it is not)

issue #994

amosfolz added some commits Jul 7, 2019

Update AdminLTE-custom.js
Update a few comments.

@amosfolz amosfolz changed the title Develop update admin lte 2.4.12 Update AdminLTE to 2.4.12 Jul 7, 2019

@amosfolz amosfolz marked this pull request as ready for review Jul 10, 2019

@amosfolz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

I just looked this over and manually tested again. Pending if @lcharette can remember what these lines were meant to fix, this is ready for merge.

@lcharette

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Pending if @lcharette can remember what these lines were meant to fix, this is ready for merge.

https://github.com/userfrosting/UserFrosting/blob/master/app/sprinkles/core/assets/userfrosting/js/AdminLTE-custom.js#L59

Overwrite here. Otherwise, the menu href based active will be removed

Not sure what that meant, but I believe it's linked to nested entries in the nav menu. Might be something that's been solved in newer version of AdminLTE.

@amosfolz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Okay, I'll test out a nested menu to make sure it's working right.

@amosfolz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

Just putting this here for reference https://adminlte.io/docs/2.4/upgrade-guide

@codecov

This comment has been minimized.

Copy link

commented Jul 11, 2019

Codecov Report

Merging #1015 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1015   +/-   ##
==========================================
  Coverage      66.93%   66.93%           
  Complexity      1913     1913           
==========================================
  Files            159      159           
  Lines           6684     6684           
==========================================
  Hits            4474     4474           
  Misses          2210     2210

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8495e...f999433. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jul 11, 2019

Codecov Report

Merging #1015 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1015   +/-   ##
==========================================
  Coverage      66.96%   66.96%           
  Complexity      1918     1918           
==========================================
  Files            160      160           
  Lines           6693     6693           
==========================================
  Hits            4482     4482           
  Misses          2211     2211

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66df775...6105a86. Read the comment docs.

@amosfolz amosfolz changed the title Update AdminLTE to 2.4.12 Update AdminLTE to 2.4.13 Jul 15, 2019

@amosfolz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

I tested the tree-view and everything worked OK.

@amosfolz amosfolz changed the title Update AdminLTE to 2.4.13 Update AdminLTE to 2.4.14 Jul 16, 2019

@lcharette

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Bump to version `2.4.15`
Only version updated.

@amosfolz amosfolz changed the title Update AdminLTE to 2.4.14 Update AdminLTE to 2.4.15 Jul 16, 2019

@lcharette

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Alright, let's freeze it on 2.4.15 for now

@lcharette lcharette merged commit a2f8304 into userfrosting:develop Jul 17, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@amosfolz amosfolz deleted the amosfolz:develop-updateAdminLTE-2.4.12 branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.