Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove league/flysystem-aws-s3-v3 and league/flysystem-rackspace as core dependencies #1018

Merged

Conversation

@amosfolz
Copy link
Contributor

commented Jul 14, 2019

I removed league/flysystem-aws-s3-v3 and league/flysystem-rackspace from the core sprinkle.

I added the configuration for rackspace to core/default.php configuration file as it was present for s3 but not rackspace. It should hopefully help make it a little easier to use that storage method.

This resolves #1016

The following sub dependencies were also removed as a result of this change:

  • Removing ralouphie/getallheaders (3.0.3)
  • Removing rackspace/php-opencloud (v1.16.0)
  • Removing mtdowling/jmespath.php (2.4.0)
  • Removing mikemccabe/json-patch-php (0.1.0)
  • Removing league/flysystem-rackspace (1.0.5)
  • Removing league/flysystem-aws-s3-v3 (1.0.23)
  • Removing guzzlehttp/psr7 (1.6.1)
  • Removing guzzlehttp/promises (v1.3.1)
  • Removing guzzlehttp/guzzle (6.3.3)
  • Removing guzzle/guzzle (v3.8.1)
  • Removing aws/aws-sdk-php (3.107.1)

amosfolz added some commits Jul 14, 2019

Remove flysystem aws-s3 and rackspace packages
The following sub dependencies were removed as a result of this change:
  - Removing ralouphie/getallheaders (3.0.3)
  - Removing rackspace/php-opencloud (v1.16.0)
  - Removing mtdowling/jmespath.php (2.4.0)
  - Removing mikemccabe/json-patch-php (0.1.0)
  - Removing league/flysystem-rackspace (1.0.5)
  - Removing league/flysystem-aws-s3-v3 (1.0.23)
  - Removing guzzlehttp/psr7 (1.6.1)
  - Removing guzzlehttp/promises (v1.3.1)
  - Removing guzzlehttp/guzzle (6.3.3)
  - Removing guzzle/guzzle (v3.8.1)
  - Removing aws/aws-sdk-php (3.107.1)
Remove extra line break in default.php
StyleCI will not complain about it but Malou will... :-)

@lcharette lcharette added this to the 4.3.0 milestone Jul 17, 2019

@lcharette

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Good. We'll just need to add the S3/rackspace dependency change to the upgrade guide and Filesystem Learn page.

@lcharette lcharette merged commit 50011f3 into userfrosting:develop Jul 17, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@amosfolz amosfolz deleted the amosfolz:develop-remove-s3-and-rackspace branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.