Conversation
Codecov Report
@@ Coverage Diff @@
## develop #937 +/- ##
==========================================
Coverage ? 35.53%
Complexity ? 2059
==========================================
Files ? 158
Lines ? 6982
Branches ? 0
==========================================
Hits ? 2481
Misses ? 4501
Partials ? 0
Continue to review full report at Codecov.
|
Silic0nS0ldier
commented
Mar 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are numerous performance and usability improvements that simply were not possible under PHP 5.6. As we look ahead to UF 4.3 the hope is that this PR will serve as a spring board, so that when 4.2 stable is out we can hit the ground running.
Changes include;
composer.json.5.6and7from the Travis build matrix.ClassMapper->staticMethodin favour of working directly with the returned class name.