Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.1 Optimisations #937

Merged
merged 7 commits into from
Jun 2, 2019
Merged

PHP 7.1 Optimisations #937

merged 7 commits into from
Jun 2, 2019

Conversation

Silic0nS0ldier
Copy link
Member

There are numerous performance and usability improvements that simply were not possible under PHP 5.6. As we look ahead to UF 4.3 the hope is that this PR will serve as a spring board, so that when 4.2 stable is out we can hit the ground running.

Changes include;

  • Increasing the minimum PHP version defined in composer.json.
  • Removing PHP versions 5.6 and 7 from the Travis build matrix.
  • Avoiding usage of ClassMapper->staticMethod in favour of working directly with the returned class name.

@Silic0nS0ldier Silic0nS0ldier added this to the 4.3.0 milestone Feb 16, 2019
@codecov
Copy link

codecov bot commented Feb 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@fc00e07). Click here to learn what that means.
The diff coverage is 20.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #937   +/-   ##
==========================================
  Coverage           ?   35.53%           
  Complexity         ?     2059           
==========================================
  Files              ?      158           
  Lines              ?     6982           
  Branches           ?        0           
==========================================
  Hits               ?     2481           
  Misses             ?     4501           
  Partials           ?        0
Impacted Files Coverage Δ Complexity Δ
app/sprinkles/core/src/Throttle/Throttler.php 27.45% <0%> (ø) 21 <0> (?)
...sprinkles/admin/src/Controller/GroupController.php 0% <0%> (ø) 61 <0> (?)
.../sprinkles/admin/src/Controller/UserController.php 0% <0%> (ø) 112 <0> (?)
...kles/admin/src/Controller/PermissionController.php 0% <0%> (ø) 12 <0> (?)
...nkles/account/src/Controller/AccountController.php 0% <0%> (ø) 85 <0> (?)
...rinkles/account/src/Repository/TokenRepository.php 0% <0%> (ø) 14 <0> (?)
app/sprinkles/account/src/Database/Models/User.php 50.89% <0%> (ø) 35 <0> (?)
...inkles/admin/src/Sprunje/PermissionUserSprunje.php 0% <0%> (ø) 3 <0> (?)
.../sprinkles/admin/src/Controller/RoleController.php 0% <0%> (ø) 80 <0> (?)
app/sprinkles/account/src/Util/Util.php 0% <0%> (ø) 4 <0> (?)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc00e07...4a450e0. Read the comment docs.

@Silic0nS0ldier Silic0nS0ldier marked this pull request as ready for review March 15, 2019 03:37
@lcharette lcharette merged commit b31d6ac into develop Jun 2, 2019
@Silic0nS0ldier Silic0nS0ldier deleted the develop-4.3-jordan branch April 18, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants