Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.1 Optimisations #937

Open
wants to merge 4 commits into
base: develop
from

Conversation

Projects
None yet
2 participants
@Silic0nS0ldier
Copy link
Member

commented Feb 16, 2019

There are numerous performance and usability improvements that simply were not possible under PHP 5.6. As we look ahead to UF 4.3 the hope is that this PR will serve as a spring board, so that when 4.2 stable is out we can hit the ground running.

Changes include;

  • Increasing the minimum PHP version defined in composer.json.
  • Removing PHP versions 5.6 and 7 from the Travis build matrix.
  • Avoiding usage of ClassMapper->staticMethod in favour of working directly with the returned class name.

@Silic0nS0ldier Silic0nS0ldier added this to the 4.3.0 milestone Feb 16, 2019

@codecov

This comment has been minimized.

Copy link

commented Feb 16, 2019

Codecov Report

Merging #937 into develop will decrease coverage by 1.17%.
The diff coverage is 20.58%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #937      +/-   ##
=============================================
- Coverage      36.79%   35.61%   -1.18%     
+ Complexity      2122     2056      -66     
=============================================
  Files            158      158              
  Lines           7216     6977     -239     
=============================================
- Hits            2655     2485     -170     
+ Misses          4561     4492      -69
Impacted Files Coverage Δ Complexity Δ
app/sprinkles/core/src/Throttle/Throttler.php 27.45% <0%> (+1.03%) 21 <0> (ø) ⬇️
...sprinkles/admin/src/Controller/GroupController.php 0% <0%> (ø) 61 <0> (ø) ⬇️
.../sprinkles/admin/src/Controller/UserController.php 0% <0%> (ø) 112 <0> (ø) ⬇️
...kles/admin/src/Controller/PermissionController.php 0% <0%> (ø) 12 <0> (ø) ⬇️
...nkles/account/src/Controller/AccountController.php 0% <0%> (ø) 85 <0> (ø) ⬇️
...rinkles/account/src/Repository/TokenRepository.php 0% <0%> (ø) 14 <0> (ø) ⬇️
app/sprinkles/account/src/Database/Models/User.php 50.89% <0%> (-0.37%) 35 <0> (ø)
...inkles/admin/src/Sprunje/PermissionUserSprunje.php 0% <0%> (ø) 3 <0> (ø) ⬇️
.../sprinkles/admin/src/Controller/RoleController.php 0% <0%> (ø) 80 <0> (ø) ⬇️
app/sprinkles/account/src/Util/Util.php 0% <0%> (ø) 4 <0> (ø) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d312d1f...10fa02c. Read the comment docs.

@Silic0nS0ldier Silic0nS0ldier marked this pull request as ready for review Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.