Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct welcome message in the italian locale #950

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
2 participants
@Poldovico
Copy link
Contributor

commented Mar 22, 2019

I noticed the welcome message in Italian is using an incorrect variable for the user's name compared to the other locales, which resulted in the name not being displayed. This PR fixes that.

Correct welcome message in the italian locale
Fixed the user's name not being displayed in the italian welcome message

@lcharette lcharette added this to the 4.2.x milestone Mar 22, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 22, 2019

Codecov Report

Merging #950 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #950      +/-   ##
============================================
- Coverage     36.79%   36.76%   -0.03%     
  Complexity     2122     2122              
============================================
  Files           158      158              
  Lines          7216     7216              
============================================
- Hits           2655     2653       -2     
- Misses         4561     4563       +2
Impacted Files Coverage Δ Complexity Δ
.../sprinkles/core/src/Session/NullSessionHandler.php 66.66% <0%> (-16.67%) 6% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d312d1f...b931934. Read the comment docs.

@lcharette lcharette changed the base branch from master to hotfix Mar 22, 2019

@lcharette lcharette self-assigned this Mar 22, 2019

@lcharette lcharette merged commit 08cf4dd into userfrosting:hotfix Mar 22, 2019

2 of 3 checks passed

codecov/project 36.76% (-0.03%) compared to d312d1f
Details
codecov/patch Coverage not affected when comparing d312d1f...b931934
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lcharette

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Thanks !

@lcharette lcharette modified the milestones: 4.2.x, 4.2.1 Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.