Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DefaultPermissions.php SQL Error #983

Merged
merged 1 commit into from May 26, 2019

Conversation

Projects
None yet
3 participants
@amosfolz
Copy link
Contributor

commented May 25, 2019

Fixed sql error when running php bakery seed DefaultPermissions as noted in issue #981

@lcharette lcharette self-assigned this May 25, 2019

@lcharette lcharette added this to the 4.2.x milestone May 25, 2019

@lcharette

This comment has been minimized.

Copy link
Member

commented May 25, 2019

@noellekimiko can you confirm this fix your issue described in #981 ?

@lcharette lcharette self-requested a review May 25, 2019

@codecov

This comment has been minimized.

Copy link

commented May 25, 2019

Codecov Report

Merging #983 into hotfix will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             hotfix     #983      +/-   ##
============================================
- Coverage     61.26%   61.05%   -0.21%     
- Complexity     2136     2212      +76     
============================================
  Files           159      159              
  Lines          7241     7478     +237     
============================================
+ Hits           4436     4566     +130     
- Misses         2805     2912     +107
Impacted Files Coverage Δ Complexity Δ
.../account/src/Database/Seeds/DefaultPermissions.php 100% <ø> (ø) 9 <0> (ø) ⬇️
...nkles/account/src/Controller/AccountController.php 18.15% <0%> (+8.49%) 165% <0%> (+76%) ⬆️
...es/admin/src/ServicesProvider/ServicesProvider.php 82.6% <0%> (+34.78%) 9% <0%> (ø) ⬇️
app/sprinkles/core/src/Util/Captcha.php 91.3% <0%> (+91.3%) 9% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f49cdd8...84e25e8. Read the comment docs.

@Silic0nS0ldier Silic0nS0ldier merged commit 910f65d into userfrosting:hotfix May 26, 2019

2 of 4 checks passed

codecov/project 61.05% (-0.21%) compared to f49cdd8
Details
continuous-integration/styleci/pr Issues have been identified with 6 files
Details
codecov/patch Coverage not affected when comparing f49cdd8...84e25e8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@amosfolz amosfolz deleted the amosfolz:hotfix-#981 branch May 26, 2019

@lcharette

This comment has been minimized.

Copy link
Member

commented May 26, 2019

Don't forget to update the Changelog when merging a PR :)

@amosfolz

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

Should I be doing that when I open PR or just on your end when you merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.