Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes UserFrosting Issue #990 - Can't set Cookie Domain of RememberMe Cookie #991

Merged
merged 4 commits into from Jun 7, 2019

Conversation

Projects
None yet
2 participants
@xrobau
Copy link
Contributor

commented Jun 4, 2019

This allows the domain to be configured in the uf4-rememberme
cookie.

lcharette and others added some commits Jun 2, 2019

Fixes UserFrosting Issue #990
This allows the domain to be configured in the uf4-rememberme
cookie.

@lcharette lcharette added this to the 4.2.x milestone Jun 4, 2019

@lcharette lcharette self-assigned this Jun 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #991 into hotfix will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             hotfix     #991      +/-   ##
============================================
+ Coverage      68.2%   68.21%   +<.01%     
- Complexity     2137     2139       +2     
============================================
  Files           159      159              
  Lines          7241     7243       +2     
============================================
+ Hits           4939     4941       +2     
  Misses         2302     2302
Impacted Files Coverage Δ Complexity Δ
...rinkles/account/src/Authenticate/Authenticator.php 92.98% <100%> (+0.12%) 41 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9ae30...9301985. Read the comment docs.

@lcharette lcharette changed the base branch from master to hotfix Jun 6, 2019

@lcharette lcharette changed the title Fixes UserFrosting Issue #990 Fixes UserFrosting Issue #990 - Can't set Cookie Domain of RememberMe Cookie Jun 6, 2019

@lcharette
Copy link
Member

left a comment

Actually, can you add remember_me.domain to the config file? This can be commented out if there's no easy way to detect the domain properly. Having all possible config option in the config file will help for discovery if someone needs this option (as I understand it's not required for base install / security reasons; correct me if I'm wrong)

@xrobau

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

Done

@lcharette

This comment has been minimized.

@lcharette lcharette merged commit 66f8e9f into userfrosting:hotfix Jun 7, 2019

4 checks passed

codecov/patch 100% of diff hit (target 68.2%)
Details
codecov/project 68.21% (+<.01%) compared to 9c9ae30
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.