Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config settings for password min/max length #993

Merged
merged 3 commits into from Jun 13, 2019

Conversation

Projects
None yet
3 participants
@avsdev-cw
Copy link
Contributor

commented Jun 5, 2019

Created some config settings for setting the min/max lengths of the password.

Due to some limitations in UserFrosting/Fortify there is no way to add the config setting name into the YAML and have it update via substitution. Where a loaded YAML is used with min/max password lengths there is an additional 2 lines per password field which updates the loaded YAML schema with the config min/max instead.

In theory this could be used to put future password complexity settings as well.

@lcharette lcharette self-requested a review Jun 5, 2019

@lcharette lcharette added this to the 4.2.x milestone Jun 5, 2019

@amosfolz

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

Can you change the config to be under the same subkey is in pending changes here: https://github.com/userfrosting/UserFrosting/pull/974/files#diff-2b7f59d74c443f25aace0c67755550d1R118

@lcharette

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Can you change the config to be under the same subkey is in pending changes here: https://github.com/userfrosting/UserFrosting/pull/974/files#diff-2b7f59d74c443f25aace0c67755550d1R118

Or maybe site => password => security ?

@avsdev-cw

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

The latter would probably be better from a future merging point of view

@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #993 into hotfix will increase coverage by 0.13%.
The diff coverage is 85.1%.

Impacted file tree graph

@@             Coverage Diff              @@
##             hotfix     #993      +/-   ##
============================================
+ Coverage      68.2%   68.34%   +0.13%     
  Complexity     2137     2137              
============================================
  Files           159      159              
  Lines          7241     7284      +43     
============================================
+ Hits           4939     4978      +39     
- Misses         2302     2306       +4
Impacted Files Coverage Δ Complexity Δ
...p/sprinkles/account/src/Bakery/CreateAdminUser.php 0% <0%> (ø) 47 <0> (ø) ⬇️
.../sprinkles/admin/src/Controller/UserController.php 100% <100%> (ø) 118 <0> (ø) ⬇️
...nkles/account/src/Controller/AccountController.php 100% <100%> (ø) 90 <0> (ø) ⬇️
.../sprinkles/admin/src/Controller/RoleController.php 100% <100%> (ø) 80 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9ae30...23546d6. Read the comment docs.

@lcharette lcharette merged commit 1044eef into userfrosting:hotfix Jun 13, 2019

4 checks passed

codecov/patch 85.1% of diff hit (target 68.2%)
Details
codecov/project 68.34% (+0.13%) compared to 9c9ae30
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.