GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Miscellaneous changes, only some code refactoring and change the enforcer rule to allow maven 3.1.1, all tests pass
Hey man. Sorry this hasn't been reviewed yet, I'm swamped at the moment, I'm hoping to get to it some time this weekend.
Can you update this PR to work with the latest master? Also, if you could, can you remove the import changes, and we'll tackle that later? We're going to add a checkstyle plugin to maven that ensures we all follow the same formatting and import rules. Until then, I think we should avoid changes like the imports and braces to keep our change sets clearer.
updated as request, thanks
Thanks man. I need to manually merge/check this since Jenkins isn't set up for this yet. I've scheduled some time to get to it on Monday.
Would it be possible to merge/rebase this onto the package rename?
@stliu I'm curious. What tool did you use to make the "miscellaneous" changes?
sorry for the late response, I just pushed a new commit which rebased to the latest master, so it can be merged fast forward
I'm using Intellij, it has a very cool code inspection tool, which can find some bad smell code and do quick fix, but mostly, I do mirror code refactor during read the code and combine them together
anyone is going to take a look of this or shall i just go head and merge it by myself?
Merge pull request #30 from stliu/Miscellaneous
Merge pull request #182 from GERey/fix-query-validator-tests
Revert pull request #30.