Miscellaneous changes #30

Merged
merged 2 commits into from Apr 21, 2014

Conversation

Projects
None yet
3 participants
Member

stliu commented Jan 19, 2014

Miscellaneous changes, only some code refactoring and change the enforcer rule to allow maven 3.1.1, all tests pass

tnine commented Jan 24, 2014

Hey man. Sorry this hasn't been reviewed yet, I'm swamped at the moment, I'm hoping to get to it some time this weekend.

tnine commented Jan 30, 2014

Hey Strong,
Can you update this PR to work with the latest master? Also, if you could, can you remove the import changes, and we'll tackle that later? We're going to add a checkstyle plugin to maven that ensures we all follow the same formatting and import rules. Until then, I think we should avoid changes like the imports and braces to keep our change sets clearer.

tnine was assigned Jan 30, 2014

Member

stliu commented Feb 6, 2014

updated as request, thanks

tnine commented Feb 7, 2014

Thanks man. I need to manually merge/check this since Jenkins isn't set up for this yet. I've scheduled some time to get to it on Monday.

tnine commented Mar 7, 2014

Would it be possible to merge/rebase this onto the package rename?

Member

snoopdave commented Mar 11, 2014

@stliu I'm curious. What tool did you use to make the "miscellaneous" changes?

Member

stliu commented Apr 17, 2014

sorry for the late response, I just pushed a new commit which rebased to the latest master, so it can be merged fast forward

I'm using Intellij, it has a very cool code inspection tool, which can find some bad smell code and do quick fix, but mostly, I do mirror code refactor during read the code and combine them together

Member

stliu commented Apr 21, 2014

anyone is going to take a look of this or shall i just go head and merge it by myself?

@snoopdave snoopdave added a commit that referenced this pull request Apr 21, 2014

@snoopdave snoopdave Merge pull request #30 from stliu/Miscellaneous
Miscellaneous changes
d4f4f84

@snoopdave snoopdave merged commit d4f4f84 into usergrid:master Apr 21, 2014

GERey referenced this pull request May 30, 2014

Merged

Revert pull request #30. #182

@tnine tnine added a commit that referenced this pull request Jun 17, 2014

@tnine tnine Merge pull request #182 from GERey/fix-query-validator-tests
Revert pull request #30.
df73ca2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment