fix(messenger-internal): pass base_url through to run() (#60)#65
Closed
anilanar wants to merge 1 commit into
Closed
fix(messenger-internal): pass base_url through to run() (#60)#65anilanar wants to merge 1 commit into
anilanar wants to merge 1 commit into
Conversation
The code change shipped in 4c1b7dc (#60) on 2026-05-13 but its commit message used the non-conventional 'internal:' prefix, which release-please doesn't recognize as a releasing type. As a result the fix has been sitting on master unreleased. This empty commit gives the fix a conventional-commit marker so release-please picks it up and includes it in the next release (a patch bump on messenger-internal, plus a cascade patch bump on messenger via the node-workspace plugin). The original change makes baseUrl available so the messenger bundle knows which origin served its loader. Backwards compatible: baseUrl is optional. Existing umm bundles ignore the new field; bundles that read it fall back to their env-baked URL when older messenger-internal omits it.
Member
Author
|
Switching to a revert+reapply approach (PR coming). Two non-empty commits will let rebase-merge actually advance master. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-opening PR #64 since the previous squash-merge didn't advance master (squash drops empty commits). This time please rebase-merge so the empty commit lands on master and release-please picks it up.
Otherwise the contents are unchanged: a single empty commit with a conventional
fix(messenger-internal):message acting as a release marker for the base_url change that shipped in 4c1b7dc (#60) on 2026-05-13.Expected outcome after rebase-merging
@userlike/messenger-internal3.3.1 → 3.3.2@userlike/messenger2.0.1 → 2.0.2 (cascade via node-workspace plugin)Test plan
git logor GH UI)