Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask the user to update the JDK installed by Rascal Extension if new release is out #280

Merged
merged 9 commits into from
Sep 25, 2023

Conversation

yami2200
Copy link
Member

@yami2200 yami2200 commented Aug 11, 2023

Automatically checks if the last jdk version is installed, if not, ask the user to update it and then download it.

Fix the #273

auto-update

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@jurgenvinju
Copy link
Member

yes, this is very nice. and necessary! thank you @yami2200

@jurgenvinju jurgenvinju self-requested a review August 14, 2023 11:04
Copy link
Member

@jurgenvinju jurgenvinju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent contribution. I had only a few minor comments; if you have time to fix these I would be grateful. Also if you don't have time, just let us know and we'll do it in the coming weeks. Groetjes!

rascal-vscode-extension/src/auto-jvm/JavaLookup.ts Outdated Show resolved Hide resolved
rascal-vscode-extension/src/auto-jvm/ReleaseInfo.ts Outdated Show resolved Hide resolved
Copy link
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, a few small points that I hope you have some time for to pickup.

rascal-vscode-extension/src/auto-jvm/JavaLookup.ts Outdated Show resolved Hide resolved
rascal-vscode-extension/src/auto-jvm/JavaLookup.ts Outdated Show resolved Hide resolved
rascal-vscode-extension/src/auto-jvm/ReleaseInfo.ts Outdated Show resolved Hide resolved
rascal-vscode-extension/src/auto-jvm/downloaders.ts Fixed Show resolved Hide resolved
rascal-vscode-extension/src/auto-jvm/downloaders.ts Fixed Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @yami2200 thanks for taking the time to process the review feedback.

@DavyLandman DavyLandman merged commit 8910ab7 into main Sep 25, 2023
9 checks passed
@DavyLandman DavyLandman deleted the jvm-update branch February 6, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants