-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask the user to update the JDK installed by Rascal Extension if new release is out #280
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
yes, this is very nice. and necessary! thank you @yami2200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent contribution. I had only a few minor comments; if you have time to fix these I would be grateful. Also if you don't have time, just let us know and we'll do it in the coming weeks. Groetjes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me, a few small points that I hope you have some time for to pickup.
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @yami2200 thanks for taking the time to process the review feedback.
Automatically checks if the last jdk version is installed, if not, ask the user to update it and then download it.
Fix the #273