New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing database file causes infinite loop in ctest #24

Open

scharlton2 opened this issue Jan 7, 2023 · 1 comment

Contributor

scharlton2 commented Jan 7, 2023

see https://github.com/usgs-coupled/phreeqc3/actions/runs/3860140795

test (macos-latest):
https://github.com/usgs-coupled/phreeqc3/actions/runs/3860140795/jobs/6580305486#step:6:924

macos-latest was the only job to finish but also created a 3.75 GB artifact. The results weren't posted to
https://my.cdash.org/index.php?project=phreeqc3.
probably rejected due to size.

Contributor Author

scharlton2 commented Jan 10, 2023

During ctest runs ANY missing input file has the same problem. ctest must continually send newlines to the process' stdin stream.

To avoid this we should probably add an environment variable check that exits immediately (when files can't be opened) -- see NPP ifdefs.

ie

set_tests_properties(${test_name} PROPERTIES ENVIRONMENT PHREEQC_EARLY_FAIL=ON)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment