Skip to content

Fixing timeline js timing out (#483) #1238

Merged
merged 2 commits into from Nov 4, 2013

2 participants

@ditorelo

Issue is being caused by selectToUISlider() plugin. It calls a jQuery::width() on each of the elements it creates for the month names (it can go up to quite a few on large time spans)

Updated function to call jQuery::width() only on the first element of the set, and letting jQuery handle the css() call for the whole collection. I suspect it will use each() internally, but I also suspect it will have smarts to do it more efficiently.

Diogo Freire added some commits Sep 11, 2013
Diogo Freire Fixing timeline js timing out (#483)
Issue if being cause by selectToUISlider() plugin. It calls a
jQuery::width() on each of the elements it creates for the month names (it
can go up to quite a few on large time spans)

Updated function to call jQuery::width() only on the first element of the
set, and letting jQuery handle the css() call for the whole collection. I
suspect it will use each() internally, but I also suspect it will have
smarts to do it more efficiently.
e6c25c6
Diogo Freire Making call a bit more efficient
Passing parent so jQuery doesn't crawl all our pretty DOM
76c3bb6
@rjmackay rjmackay merged commit 093a3ed into ushahidi:develop Nov 4, 2013
@ditorelo ditorelo deleted the unknown repository branch Nov 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.