Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's a random hover state for the time metadata #2277

Closed
5 tasks
justinscherer opened this issue Nov 1, 2017 · 7 comments
Closed
5 tasks

There's a random hover state for the time metadata #2277

justinscherer opened this issue Nov 1, 2017 · 7 comments
Assignees
Labels
Bug Codebase: Client Indicates issue work will be in client good-first-issue Issues that are ideal for first time contributors to OSS or first time contributing to the platform Hacktoberfest Issues open to folks participating in hacktoberfest Theme: Data View

Comments

@justinscherer
Copy link

justinscherer commented Nov 1, 2017

Expected behaviour

hover state on postcard should show full date and time

Actual behaviour

screen shot 2017-11-01 at 2 06 41 pm

Steps to reproduce the behaviour/error

hover cursor over time metadata in postcard

Where
@rjmackay
Copy link
Contributor

rjmackay commented Nov 1, 2017

Thats broken. The hover state is supposed to show the full date + time of the event (similar to times shown on github).
If you want to replace that hover state, is there somewhere else we can present that info?

@justinscherer
Copy link
Author

The hover state is supposed to show the full date + time of the event (similar to times shown on github).

Ok that makes sense. I just couldn't figure out what it was trying to show me. It should remain, but show the full date and time, then.

@rowasc
Copy link
Contributor

rowasc commented Jun 11, 2019

other examples for dates before today. Still broken.

Screen Shot 2019-06-10 at 22 57 49

Screen Shot 2019-06-10 at 22 58 22

This is likely a good first issue for someone familiar with AngularJS

@rowasc rowasc added Codebase: Client Indicates issue work will be in client good-first-issue Issues that are ideal for first time contributors to OSS or first time contributing to the platform Theme: Data View and removed P1 - Immediate labels Jun 11, 2019
@Erioldoesdesign
Copy link

This styling isn't very accessible...it'd be nice to design something that is accessible...

@Erioldoesdesign Erioldoesdesign self-assigned this Jul 9, 2019
@rowasc
Copy link
Contributor

rowasc commented Aug 17, 2019

@Erioldoesdesign should we open this up for W/S/C OSS design contributors or did you start working on it ?

@rowasc rowasc added the Hacktoberfest Issues open to folks participating in hacktoberfest label Sep 28, 2019
@AlanaFarkas
Copy link

Hi,

I'd like to pick this ticket up!

@rowasc
Copy link
Contributor

rowasc commented Nov 15, 2019

awesome, thank you. !

@rowasc rowasc closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Codebase: Client Indicates issue work will be in client good-first-issue Issues that are ideal for first time contributors to OSS or first time contributing to the platform Hacktoberfest Issues open to folks participating in hacktoberfest Theme: Data View
Projects
None yet
Development

No branches or pull requests

6 participants