New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from collection to saved search does not update url #2323

Open
Angamanga opened this Issue Nov 29, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@Angamanga
Contributor

Angamanga commented Nov 29, 2017

Expected behaviour

When I move from a collection to a saved search, the url should update accordingly

Actual behaviour

The collection-url is still visible although I am looking at a saved search

Steps to reproduce the behaviour/error

  1. select a collection with dataview as default
  2. select a saved search, click apply filters
  3. look at the url, its still the collection-url
Where
@rowasc

This comment has been minimized.

Show comment
Hide comment
@rowasc

rowasc Nov 29, 2017

Contributor

@Angamanga @rjmackay yea. That's expected right now :( Robbie and I discussed it a couple days ago.. and we're still kind of trying to figure this one out. Basically, there are a lot of decisions to make regarding collections. The URL after you change to a saved search is no longer affecting you tho, so that's good. (confusing .. but, good)

Contributor

rowasc commented Nov 29, 2017

@Angamanga @rjmackay yea. That's expected right now :( Robbie and I discussed it a couple days ago.. and we're still kind of trying to figure this one out. Basically, there are a lot of decisions to make regarding collections. The URL after you change to a saved search is no longer affecting you tho, so that's good. (confusing .. but, good)

@Angamanga

This comment has been minimized.

Show comment
Hide comment
@Angamanga

Angamanga Nov 29, 2017

Contributor

@rowasc Just adding the last finds I could find after testing, probably low prio though :)

Contributor

Angamanga commented Nov 29, 2017

@rowasc Just adding the last finds I could find after testing, probably low prio though :)

@rowasc

This comment has been minimized.

Show comment
Hide comment
@rowasc

rowasc Nov 29, 2017

Contributor

ha yea I know :) sorry I was just nothing this to make sure that we had context . Thanks @Angamanga !

Contributor

rowasc commented Nov 29, 2017

ha yea I know :) sorry I was just nothing this to make sure that we had context . Thanks @Angamanga !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment