New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New inbound SMS start new Posts AND appear on existing Posts' conversations with Author section #2343

Closed
willdoran opened this Issue Dec 5, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@willdoran
Member

willdoran commented Dec 5, 2017

Expected behaviour

  • The conversation with an Author does not spawn new Posts each time the Author responds

Actual behaviour

  • Each time the Author responds a new Post is created

Steps to reproduce the behaviour/error

  • Requires: Datasource SMS setup
  • Receive an inbound SMS
  • Go to the Post created for this inbound SMS
  • Using the Conversation with Author section
  • Send a reply to the Author
Where
@jshorland

This comment has been minimized.

Show comment
Hide comment
@jshorland

jshorland Feb 14, 2018

This should be fixed within the SMS targeted surveys

jshorland commented Feb 14, 2018

This should be fixed within the SMS targeted surveys

@jshorland jshorland added this to the SMS targeted surveys cycle 1 milestone Feb 14, 2018

@jshorland jshorland removed the Needs Triage label Feb 27, 2018

@rowasc rowasc self-assigned this Feb 28, 2018

@rowasc

This comment has been minimized.

Show comment
Hide comment
@rowasc

rowasc Feb 28, 2018

Contributor

@willdoran this is in Core/Usecase/Message/ReceiveMessage.php when sending a POST to smsync or any of the sms providers with to/from/message fields right?
(def. need to up my platform dataproviders/SMS knowledge this cycle!)

Contributor

rowasc commented Feb 28, 2018

@willdoran this is in Core/Usecase/Message/ReceiveMessage.php when sending a POST to smsync or any of the sms providers with to/from/message fields right?
(def. need to up my platform dataproviders/SMS knowledge this cycle!)

@rowasc rowasc closed this Feb 28, 2018

@rowasc rowasc reopened this Feb 28, 2018

@rowasc

This comment has been minimized.

Show comment
Hide comment
@rowasc

rowasc Feb 28, 2018

Contributor

First sent two messages to /smssync
screen shot 2018-02-28 at 2 45 33 pm
Then answered and sent another message and this was the result
screen shot 2018-02-28 at 2 59 48 pm

Q1 : So if I'm in the data view, for instance, it would be shown under the conversation with author but not in the sidebar of posts. Right?
Q2: not sure how Eve would test this? directly with SMS or should we send her a postman set up for this?

Contributor

rowasc commented Feb 28, 2018

First sent two messages to /smssync
screen shot 2018-02-28 at 2 45 33 pm
Then answered and sent another message and this was the result
screen shot 2018-02-28 at 2 59 48 pm

Q1 : So if I'm in the data view, for instance, it would be shown under the conversation with author but not in the sidebar of posts. Right?
Q2: not sure how Eve would test this? directly with SMS or should we send her a postman set up for this?

@willdoran

This comment has been minimized.

Show comment
Hide comment
@willdoran

willdoran Feb 28, 2018

Member

@rowasc

  1. This is already covered by the SMS Feature issue #2532
  2. We have test accounts for both nexmo and twillio, we should have one for frontlinesms those have numbers that are text able to text
Member

willdoran commented Feb 28, 2018

@rowasc

  1. This is already covered by the SMS Feature issue #2532
  2. We have test accounts for both nexmo and twillio, we should have one for frontlinesms those have numbers that are text able to text
@willdoran

This comment has been minimized.

Show comment
Hide comment
@willdoran

willdoran Feb 28, 2018

Member

Closing in favour of #2532

Member

willdoran commented Feb 28, 2018

Closing in favour of #2532

@willdoran willdoran closed this Feb 28, 2018

@rowasc

This comment has been minimized.

Show comment
Hide comment
@rowasc

rowasc Feb 28, 2018

Contributor

makes sense thanks

Contributor

rowasc commented Feb 28, 2018

makes sense thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment