New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings => General page - not all fields show a validation error when they are invalid #3304

Open
rowasc opened this Issue Sep 27, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@rowasc
Contributor

rowasc commented Sep 27, 2018

Describe the bug
Some fields like Contact Email Address and default lat/lon values do not show anything to the user if they have invalid values. This is confusing and prevents the user from saving the page until they solve the issue, but they don't have feedback about what's wrong.

Where was the bug observed

  • Development branch (locally)
  • Community support channel where a user reported that they cannot save the settings

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings -> General
  2. In the Contact Email Address field, write an invalid email like hello
  3. You won't see any error messages and the save button will be disabled.

Expected behavior

  1. Go to Settings -> General
  2. In the Contact Email Address field, write an invalid email like hello
  3. You see a validation error message for the field
  4. The save button is disabled until the error is fixed

Is there a workaround? What is it.
Just fixing the errors, but since the user doesn't know the validation rules this might be confusing/tricky to do.

Screenshots
screen shot 2018-09-27 at 2 57 33 pm

Implementation Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment