New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize the youtube and vimeo logos so they aren't blurry in survey creation #3320

Open
Erioldoesdesign opened this Issue Oct 8, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@Erioldoesdesign

Erioldoesdesign commented Oct 8, 2018

As a user, when responding to a survey that has a field available for video URL, I see a YouTube logo and Vimeo logo that are blurred. I want to see non-blurry logos for each of these.

Suggest either resizing/locating larger logos and replacing existing files
or
Editing current CSS styling to fit the natural image size
or
Substitute with Font Awesome Icons.

Screen Shot 2018-10-08 at 22.00.58.png

QA on multiple devices/browsers please

@actuallyakash

This comment has been minimized.

Show comment
Hide comment
@actuallyakash

actuallyakash Oct 9, 2018

Why don't you use Font Awesome icons for this?

actuallyakash commented Oct 9, 2018

Why don't you use Font Awesome icons for this?

@Erioldoesdesign

This comment has been minimized.

Show comment
Hide comment
@Erioldoesdesign

Erioldoesdesign Oct 9, 2018

@sky1911 Oh! great suggestion. 100% in favour of substituting for font awesome icons but would need to be QA'd on lots of different devices for my peace of mind :)

Erioldoesdesign commented Oct 9, 2018

@sky1911 Oh! great suggestion. 100% in favour of substituting for font awesome icons but would need to be QA'd on lots of different devices for my peace of mind :)

@rowasc

This comment has been minimized.

Show comment
Hide comment
@rowasc

rowasc Oct 9, 2018

Contributor

@Angamanga I see font-awesome is already added in the PL but it's not being applied correctly when I use the FA classes, probably some bug?

(following up from our slack convo, see Skky1911's and Eriol's comment above)

Contributor

rowasc commented Oct 9, 2018

@Angamanga I see font-awesome is already added in the PL but it's not being applied correctly when I use the FA classes, probably some bug?

(following up from our slack convo, see Skky1911's and Eriol's comment above)

@actuallyakash

This comment has been minimized.

Show comment
Hide comment
@actuallyakash

actuallyakash Oct 12, 2018

@rowasc maybe you're using the classes from FA 5.0 (newest version) and the FA embedded on the website is an older version.

actuallyakash commented Oct 12, 2018

@rowasc maybe you're using the classes from FA 5.0 (newest version) and the FA embedded on the website is an older version.

@rowasc

This comment has been minimized.

Show comment
Hide comment
@rowasc

rowasc Oct 15, 2018

Contributor

@actuallyakash very likely. If you try it and figure it out let us know :)

Contributor

rowasc commented Oct 15, 2018

@actuallyakash very likely. If you try it and figure it out let us know :)

@Angamanga

This comment has been minimized.

Show comment
Hide comment
@Angamanga

Angamanga Oct 16, 2018

Contributor

@rowasc @actuallyakash Sorry I didn't follow up on this. The font-awesome font files are left over from a while ago. We no longer use it but its worth a try. (Otherwise we should really remove it, but will watch this and see how it goes first).

Contributor

Angamanga commented Oct 16, 2018

@rowasc @actuallyakash Sorry I didn't follow up on this. The font-awesome font files are left over from a while ago. We no longer use it but its worth a try. (Otherwise we should really remove it, but will watch this and see how it goes first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment