New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo accounts] Add post button on data view is covered by "Upgrade now" banner #3323

Open
sinneruy opened this Issue Oct 9, 2018 · 7 comments

Comments

Projects
None yet
6 participants
@sinneruy

sinneruy commented Oct 9, 2018

Problem

Add post button on data view is covered by "Upgrade now" banner.

Steps to reproduce the behavior:

  1. Go to https://hacktoberfesttest.ushahidi.io/views/data
  2. Log in as any role that can add posts.
  3. Add post button is below the "upgrade now" banner.
  • OS: Windows 10 pro
  • Browser FF dev edition 63.0b11 (64-bit) / Chrome 69.0.3497.100

Workaround

  • Add from map view

@rowasc rowasc changed the title from Add post button on data view is covered by "Upgrade now" banner to [Demo accounts] Add post button on data view is covered by "Upgrade now" banner Oct 9, 2018

@rowasc

This comment has been minimized.

Show comment
Hide comment
@rowasc

rowasc Oct 9, 2018

Contributor

@Erioldoesdesign @justinscherer what should we do about the add post button here?
screen shot 2018-10-09 at 4 34 52 pm

Thanks @sinneruy for the bug report :)

Contributor

rowasc commented Oct 9, 2018

@Erioldoesdesign @justinscherer what should we do about the add post button here?
screen shot 2018-10-09 at 4 34 52 pm

Thanks @sinneruy for the bug report :)

@rowasc

This comment has been minimized.

Show comment
Hide comment
@rowasc

rowasc Oct 9, 2018

Contributor

Pinging @sethburtonhall since he might know what to do here

Contributor

rowasc commented Oct 9, 2018

Pinging @sethburtonhall since he might know what to do here

@justinscherer

This comment has been minimized.

Show comment
Hide comment
@justinscherer

justinscherer Oct 9, 2018

Nice catch. Shift the button 24px above the banner. Should solve it.

justinscherer commented Oct 9, 2018

Nice catch. Shift the button 24px above the banner. Should solve it.

@sethburtonhall

This comment has been minimized.

Show comment
Hide comment
@sethburtonhall

sethburtonhall Oct 9, 2018

Member

@justinscherer @rowasc we will have to accommodate for various screen sizes which is fine, but there may be a need for logic to change display based on whether demo bar is true or false

Member

sethburtonhall commented Oct 9, 2018

@justinscherer @rowasc we will have to accommodate for various screen sizes which is fine, but there may be a need for logic to change display based on whether demo bar is true or false

@Erioldoesdesign

This comment has been minimized.

Show comment
Hide comment
@Erioldoesdesign

Erioldoesdesign Oct 10, 2018

Is there a z-index on the add post button? If so would be bringing it forward 'layer' wise be a simple fix?

It has a drop shadow so shouldn't blend into the yellow of the banner. Thoughts?

(also pro moving it too but as Seth says, it might be wonky on different sizes)

Erioldoesdesign commented Oct 10, 2018

Is there a z-index on the add post button? If so would be bringing it forward 'layer' wise be a simple fix?

It has a drop shadow so shouldn't blend into the yellow of the banner. Thoughts?

(also pro moving it too but as Seth says, it might be wonky on different sizes)

@sethburtonhall

This comment has been minimized.

Show comment
Hide comment
@sethburtonhall

sethburtonhall Oct 10, 2018

Member

@Angamanga has a good solution here

Member

sethburtonhall commented Oct 10, 2018

@Angamanga has a good solution here

@Erioldoesdesign

This comment has been minimized.

Show comment
Hide comment
@Erioldoesdesign

Erioldoesdesign Oct 10, 2018

@sethburtonhall I much prefer this solution. Thorough and will make for neat code/structure :)

Erioldoesdesign commented Oct 10, 2018

@sethburtonhall I much prefer this solution. Thorough and will make for neat code/structure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment