Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get familiar with the users-list code #3540

Open
Angamanga opened this issue May 28, 2019 · 0 comments

Comments

3 participants
@Angamanga
Copy link
Contributor

commented May 28, 2019

BACKGROUND
The user-list is found when clicking on "Settings" and then "Users". It is the list that shows what users are present in the deployment. We will start moving over tis section over to React. The code is found here:

Directive: https://github.com/ushahidi/platform-client/blob/js-migration/app/settings/users/users.controller.js

Html-template: https://github.com/ushahidi/platform-client/blob/js-migration/app/settings/users/users.html

Tests: https://github.com/ushahidi/platform-client/blob/js-migration/test/unit/settings/users/users-controller-spec.js

TODO

  • Start with read through the tests, this gives you an idea what the code is supposed to do
  • Check the functions in the directive, console.log or step through the functionality with breakpoints in Chrome-dev-tools to get an idea what is happening when the page loads
  • Try changing things and text on the page. For example exchange the users name with permission and things like that
  • Figure out what smaller parts could be "isolated" from the rest of the code and be moved to React, write a list of those in this issue.

@Angamanga Angamanga created this issue from a note in JS-migration (Current week) May 28, 2019

@Angamanga Angamanga referenced this issue May 28, 2019

Open

Start with moving over a little piece #3541

0 of 22 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.