Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client pre-build checks #3549

Open
tuxpiper opened this issue Jun 5, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@tuxpiper
Copy link
Member

commented Jun 5, 2019

Add a routine in the build process that checks:

  • If the .env file exists, whether the file is readable and has no formatting errors
  • Whether the BACKEND_URL variable is set. This can be because it's provided via the .env file, or directly in the environment variables of the process
  • Whether the TX_USERNAME and TX_PASSWORD variables (Transifex credentials) are set.

Console outputs (better if we make this coloured so that they stand out in the output)

  • Error, if no BACKEND_URL is available
  • Info, prominently displaying the BACKEND_URL that the build is being made for
  • Warning, if no Transifex credential variables are set, clarifying that only English language will be available, and if a multi-language interface is required, a Transifex account is necessary.

Expert mode:

  • If the env variable USH_DISABLE_CHECKS is set, skip all this

Implementation approach:

I see two alternatives here,

  1. A program separate from gulp, that is invoked via npm by a specific hook
  2. Additional step in the gulp chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.