Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Categories Enhancements/Refactoring #3632

Open
crcommons opened this issue Nov 7, 2017 · 1 comment

Comments

@crcommons
Copy link
Contributor

commented Nov 7, 2017

The behaviour of the categories are still unclear and needs a walkthrough again. The behaviour for creating, using and filtering for categories is probably not always clear to the user and the behaviour of the code might not align with how the user would think it behaves.
@justinscherer @aoduor @jshorland We tried to do an audit of how categories currently works and how it should work. Can you look through this and edit as needed? Then hopefully we can break down into more manageable issues/tasks.

Creating a category
Current behaviour:

  • The child does not always have the same permissions as the parent in the API, but does according to the client #2010)
  • A category that has children cannot be a child itself
  • A newly created category doesn't automatically get assigned to a survey, that always happens in the survey-editor
    Intended behavior (changes)
  • A child should always have the same permissions as the parent in both the API and the Client

Adding a category to a survey
Current behaviour

  • Categories are added to a survey through the editor
  • You can add a parent without adding a child
  • You cannot add a child to a survey without adding its parent too
    Intended behavior (changes)
  • You should not be able to add a parent without adding a child, but you don’t have to add all children

Selecting a category when adding a post
Current behavior

  • Categories that a user have permissions to see are visible
  • You can select a parent without selecting a child
  • You cannot select a child without selecting a parent
  • Users with 'Manage Settings' permissions see a + Add Category below the categories-list.
  • The newly added category currently does not show up unless you refresh page
  • When a user adds a category on the fly to a post, it is added as a category option in that survey and no other surveys, visible to everyone.
    Intended Behavior (changes)
  • You should not be able to select a parent without selecting a child
  • When you add a category on the fly, it should show in the list of categories in that current post
  • What users should have permissions to add categories to a post? @jshorland

Viewing categories in a post
Current behaviour

  • Only users with permissions can see categories in a post;
    Intended behavior (changes)
  • Categories that are viewable to “Everyone” should be seen by everyone
  • @jshorland @justinscherer Clarity on intended behavior here?

Filtering by categories
Current behaviour

  • In mode-context-bar in map-view
  • Categories can only be filtered for one survey at a time
  • When selecting a parent in the dropdown-menu, the children becomes visible
  • A child cannot be selected without its parent
  • All other surveys gets deselected
  • In filters dropdown
  • Only categories that the user have permissions to see are present in the filter-dropdown (is this the same in mode-context?<-- yes)
  • Category filters essentially don’t work at all
    Intended behavior (changes)
    @jshorland @justinscherer What is intended behavior here?
@willdoran

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2017

Questions:

  1. What is the distinction between a category and a tag?
  2. From a user perspective I am familiar with tagging in that I expect tagging to be global, and very immediate. I don't expect to have to edit a post to tag it. If there is a distinction between category and tag, is tag a function that we want to (re)introduce? I would find it hugely useful from the point of view roughly marking up posts for different kinds of attention or adding quick meta data.
  3. We seem to have multiple ways to class data within the platform, savedsearch/collections/categories/surveys. Do we have general assessment of these and their purposes?

@rowasc rowasc transferred this issue from ushahidi/platform-client Aug 11, 2019

@rowasc rowasc added the Needs Triage label Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.