Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong intercom link if intercomAppId is not set #3769

Open
trendspotter opened this issue Aug 29, 2018 · 2 comments

Comments

@trendspotter
Copy link

commented Aug 29, 2018

Expected behaviour

Intercom link under Ushahidi support menu should be hidden when intercomAppId is not set in config.js.

Actual behaviour

When intercomAppId is not set in config.js or is set to empty string, displayed Intercom menu item leads to bogus address @intercom-mail.com

Steps to reproduce the behaviour/error

  1. Install Ushahidi 3.12.3.
  2. Don't fill any value for intercomAppId in config.js.
  3. Login to Ushahidi.
  4. Click on Ushahidi support menu item (bottom left).
  5. Observe address in Intercom link.
@rowasc rowasc transferred this issue from ushahidi/platform-client Sep 20, 2019
@rowasc

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

@all-contributors please add @trendspotter for bug
Thank you for reporting a bug !

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

@rowasc

I've put up a pull request to add @trendspotter! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.