Urban Škudnik uskudnik

Organizations

@kiberpipa
uskudnik commented on pull request google/ggrc-core#3027
@uskudnik

@Smotko Merged your PR, fixed type to be consistent across the board regardless if the setting is set or not

@uskudnik
  • @uskudnik ef00ca2
    Use the same type regardless if the setting is set
uskudnik commented on pull request google/ggrc-core#3027
@uskudnik

:+1:

@uskudnik
uskudnik merged pull request uskudnik/ggrc-core#4
@uskudnik
Add AUTHORIZED_DOMAINS to deploy_appengine
1 commit with 2 additions and 1 deletion
@uskudnik
  • @uskudnik 69c0dcb
    Correct Git managment suggested `pr` alias
uskudnik opened pull request google/ggrc-core#3056
@uskudnik
Fetch PR and merge latest upstream develop into PR
1 commit with 1 addition and 1 deletion
uskudnik commented on issue google/ggrc-core#2666
uskudnik commented on pull request google/ggrc-core#3028
@uskudnik

Agreed, my arguments against are along the lines of stuff listed here: http://stackoverflow.com/questions/500504/why-is-using-for-in-with-array-ite…

uskudnik commented on pull request google/ggrc-core#3028
@uskudnik

:+1:

uskudnik commented on pull request google/ggrc-core#3028
@uskudnik

I would avoid style but I can understand it (not wanting to touch SCSS).

uskudnik commented on pull request google/ggrc-core#3028
@uskudnik

If I'm reading this right - since already_visible is an array and not an object, wouldn't regular for loop be more appropriate (maybe even faster b…

@uskudnik
  • @uskudnik b520f1b
    Add cycle object explicitly to session
@uskudnik
  • @uskudnik 0a9e478
    Remove string processing - switch to sets for option instead of strin…
uskudnik opened pull request google/ggrc-core#3027
@uskudnik
Feature/core 2168 users from authorised domains become creators
2 commits with 24 additions and 1 deletion
@uskudnik
  • @uskudnik b3e1373
    Add new line to settings/default.py
uskudnik opened pull request google/ggrc-core#3026
@uskudnik
Rename 'Test Plan' to 'Remedition Plan' for issue object
1 commit with 24 additions and 4 deletions
uskudnik commented on pull request google/ggrc-core#3023
@uskudnik

:+1:

uskudnik opened pull request google/ggrc-core#3025
@uskudnik
Remove "Show/Hide filter" for admin dashboard
1 commit with 2 additions and 0 deletions
uskudnik closed pull request google/ggrc-core#3020
@uskudnik
CORE-2173 Limit the amount of simultaneous mappings
uskudnik commented on pull request google/ggrc-core#3020
@uskudnik

Wouldn't something like GGRC.config.MAX_INSTANCES || 1 be better?

uskudnik opened pull request google/ggrc-core#3023
@uskudnik
Fix cycle task validation, cycle ending, calculations involving partial cycles
1 commit with 201 additions and 3 deletions
uskudnik commented on pull request google/ggrc-core#3011
@uskudnik

Because there are a lot of controls with means_id already set to NULL - this should avoid redoing that (I hope SQL is optimising a bit here under t…