Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federation errata #1932

Merged
merged 14 commits into from Jun 13, 2019

Conversation

2 participants
@jricher
Copy link
Collaborator

commented May 13, 2019

No description provided.

@jricher jricher requested a review from jimfenton May 13, 2019

@jimfenton
Copy link
Collaborator

left a comment

Comments on some of the commits included. Also, I'd like to include an errata table (see page vii of the PDF version) this time around to be more consistent between the PDF and online. Please include the things in the table from the first errata round as well.

Show resolved Hide resolved sp800-63c/sec1_2_introduction.md
Show resolved Hide resolved sp800-63c/sec4_fal.md Outdated
Show resolved Hide resolved sp800-63-3/definitions.md Outdated

@jricher jricher changed the base branch from nist-pages to errata-2 May 16, 2019

@jimfenton
Copy link
Collaborator

left a comment

Thanks for adding the errata tables. Usual nitpicky comments attached.

Show resolved Hide resolved sp800-63-3/errata.md Outdated
Show resolved Hide resolved sp800-63-3/errata.md Outdated
Show resolved Hide resolved sp800-63-3/errata.md Outdated
Show resolved Hide resolved sp800-63a/errata.md Outdated
Show resolved Hide resolved sp800-63a/errata.md Outdated
Show resolved Hide resolved sp800-63a/errata.md Outdated
Show resolved Hide resolved sp800-63b/errata.md Outdated
Show resolved Hide resolved sp800-63c/sec6_assertions.md
Show resolved Hide resolved sp800-63c/sec9_privacy.md
@jimfenton

This comment has been minimized.

Copy link
Collaborator

commented Jun 12, 2019

There were a few smart/curly quotes still there, some of which were pre-existing. I think my script has caught all of them (for now).

@jimfenton
Copy link
Collaborator

left a comment

All set now.

@jimfenton jimfenton merged commit 7a7ecdb into errata-2 Jun 13, 2019

@jimfenton jimfenton added the 63A label Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.