Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong cell to cell normal in periodic meshes #205

Closed
fipymigrate opened this issue Sep 19, 2014 · 4 comments
Closed

wrong cell to cell normal in periodic meshes #205

fipymigrate opened this issue Sep 19, 2014 · 4 comments
Milestone

Comments

@fipymigrate
Copy link

@fipymigrate fipymigrate commented Sep 19, 2014

For a periodic mesh, the cell to cell normal is wrong.

See attached example test code ben_bug02.py, the cell to cell normal on one of the faces where there is periodicity is pointing opposite the face normal.

Patch celcelnormal.diff contains the fix: call update on cell-cell normal calculation after the connect faces code

Imported from trac ticket #301, created by benny.malengier@gmail.com on 06-30-2010 at 17:58, last modified: 06-20-2011 at 16:30

@fipymigrate fipymigrate added this to the 3.0 milestone Sep 19, 2014
@fipymigrate
Copy link
Author

@fipymigrate fipymigrate commented Sep 19, 2014

benny.malengier@gmail.com attached ben_bug02.py on 06-30-2010 at 17:58

@fipymigrate
Copy link
Author

@fipymigrate fipymigrate commented Sep 19, 2014

benny.malengier@gmail.com attached celcelnormal.diff on 06-30-2010 at 17:58

@fipymigrate
Copy link
Author

@fipymigrate fipymigrate commented Sep 19, 2014

The reason this patch is needed is when inheriting classes of fipy, and eg using the concatenate code, terms like DiffusionTerm will not work as they use cell to cell normal when the grid is not orthogonal (creating an antidiffusion).

Trac comment by benny.malengier@gmail.com on 06-30-2010 at 18:24

@wd15
Copy link
Contributor

@wd15 wd15 commented Sep 19, 2014

Fixed with r4630.

Trac comment by wd15 on 06-20-2011 at 16:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants