New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UAS loop detection configuration #28

Merged
merged 2 commits into from Jul 24, 2017

Conversation

Projects
None yet
4 participants
@simonlg

simonlg commented Jul 21, 2017

We currently have an application using the Jain SIP which is a UAS acting as a redirect server. Within our infrastructure, due to the redundancy model, it is possible for the same INVITE to be sent twice to our redirect UAS.

Here's the flow

In rfc3261 section 8.2.2.2, it says:

"If the request has no tag in the To header field, the UAS core MUST
check the request against ongoing transactions. If the From tag,
Call-ID, and CSeq exactly match those associated with an ongoing
transaction, but the request does not match that transaction (based
on the matching rules in Section 17.2.3), the UAS core SHOULD
generate a 482 (Loop Detected) response and pass it to the server
transaction."

Being optional, I propose to add a configuration which allows the disabling of the loop detection. I'm not a 100% certain on the naming of my configuration.

Simon Lavigne-Giroux added some commits Jul 20, 2017

@@ -1,6 +1,7 @@
package gov.nist.javax.sip;
import javax.sip.SipProvider;
import javax.sip.SipStack;

This comment has been minimized.

@jagliot

jagliot Jul 21, 2017

Collaborator

import not needed

@jagliot

jagliot Jul 21, 2017

Collaborator

import not needed

@@ -934,6 +934,10 @@ public SipStackImpl(Properties configurationProperties)
if ( super.isAutomaticDialogSupportEnabled ) {
super.isAutomaticDialogErrorHandlingEnabled = true;
}
super.isServerLoopDetectionEnabled = configurationProperties

This comment has been minimized.

@jagliot

jagliot Jul 21, 2017

Collaborator

needs formatting

@jagliot

jagliot Jul 21, 2017

Collaborator

needs formatting

@@ -1919,6 +1923,10 @@ public boolean isBackToBackUserAgent() {
public boolean isAutomaticDialogErrorHandlingEnabled() {
return super.isAutomaticDialogErrorHandlingEnabled;
}
public boolean isServerLoopDetectionEnabled() {
return super.isServerLoopDetectionEnabled;

This comment has been minimized.

@jagliot

jagliot Jul 21, 2017

Collaborator

needs formatting

@jagliot

jagliot Jul 21, 2017

Collaborator

needs formatting

@vladimirralev

This comment has been minimized.

Show comment
Hide comment
@vladimirralev

vladimirralev Jul 22, 2017

Collaborator

Thanks. Looks like a useful addition to me.

@simonlg You may want to redo or modify the commits since currently they are made from unrecognized email (...@bell.ca), not associated with you in github, which means they will most likely not point to your account. I am not sure if you will get proper credit this way. Let us know if you want to redo or keep the current author metadata.

Collaborator

vladimirralev commented Jul 22, 2017

Thanks. Looks like a useful addition to me.

@simonlg You may want to redo or modify the commits since currently they are made from unrecognized email (...@bell.ca), not associated with you in github, which means they will most likely not point to your account. I am not sure if you will get proper credit this way. Let us know if you want to redo or keep the current author metadata.

@ranganathanm

This comment has been minimized.

Show comment
Hide comment
@ranganathanm

ranganathanm Jul 24, 2017

Member
Member

ranganathanm commented Jul 24, 2017

@ranganathanm ranganathanm merged commit d9fbfe3 into usnistgov:master Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment