Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for JSIP-519: OriginFieldParser skips session id and session version #4

Merged
merged 1 commit into from Jul 11, 2016

Conversation

fre42
Copy link
Contributor

@fre42 fre42 commented Jul 11, 2016

Although SDP RFC 4566 does not limit the sess-id and sess-version field the NIST implementation of gov.nist.javax.sdp.parser.OriginFieldParser limits the fields to 18 digits.
This has been done because the jain.sip API used a Java long field for the session-id and session-version.
Unfortunately the JAVA long allows up to 19 digits (see Long.MAX_VALUE) which means that the SDP parser does not allow the full possible range of values to be used with JAVA long.
The Mozilla Firefox Browser in WebRTC environment created SDP containing the session-id value using the full range for the long value and therefore the first digit may be cut by the current code of OriginFieldParser.java.
My attached simple patch allows to use the full value range of Long.MAX_VALUE.

@ranganathanm ranganathanm merged commit 158e95c into usnistgov:master Jul 11, 2016
@ranganathanm
Copy link
Member

Thanks for your fix. Ranga

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants