Fix udp hole punching #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those functions send appropriate packets. But it's not like they are called 'from' those states (syn, ack-ack, etc.) like 'recv_from_syn'. Therefore, the names were misleading and didn't follow the naming logic of the rest of the code.
Will be possible to reuse code.
|
Actually, the fix is done, but I'd like to write some tests for the fixed function which I haven't figured out how to do yet. |
Send the final ack-ack messages - without them remote peer sometimes gets lost. Before these changes that was just a dummy recursion doing nothing.
When response timesout after messages (syn, ack, etc.), we used to retry the message and extend the previous timeout by 200 miliseconds. But in reality because of network latency and CPU execution time we might leave only a fraction of time for the future message. Or even worse case, we might specify timeout that is already finished. This little change makes sure we give at least 200 miliseconds for each response to arrive.
povilasb
force-pushed
the
fix/udp-hole-punching
branch
from
8e6d8ac
to
cc1041f
Compare
canndrew
approved these changes
Jan 22, 2018
ustulation
approved these changes
Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed final ack-ack message sending.