Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Documentation: Add uswds-react implementation from Trussworks. #1003

Merged
merged 4 commits into from
Jul 28, 2020

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Jul 14, 2020

Description

Resolves #1002. Added this react implementation of USWDS by Trussworks.

Preview 👁

Additional information

I know there's also this react implementation by Paul Arce, but it looks like it hasn't been updated.

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj mejiaj self-assigned this Jul 14, 2020
Copy link
Contributor

@afeijoo afeijoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mejiaj The implementations are listed in A-Z order by the Distribution column. Can you please move this React row and it between the Rails gem and Ruby gem rows?

List alphabetically based on `distribution` column.
@mejiaj
Copy link
Contributor Author

mejiaj commented Jul 14, 2020

Updated, I didn't make that connection. Thanks for that!

@thisisdano thisisdano changed the base branch from master to main July 20, 2020 20:20
@thisisdano thisisdano merged commit a298edb into main Jul 28, 2020
@thisisdano thisisdano deleted the jm-add-react-implementation branch July 28, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Truss USWDS React to Implementations Page
3 participants